Skip to content

feat(BA-530): Update SDK and CLI to follow-up per-user uid/gid #3361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 5, 2025
Merged

feat(BA-530): Update SDK and CLI to follow-up per-user uid/gid #3361

merged 4 commits into from
Feb 5, 2025

Conversation

fregataa
Copy link
Member

@fregataa fregataa commented Jan 3, 2025 •
edited
Loading

resolves #3479 (BA-530)

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version
  • API server-client counterparts (e.g., manager API -> client SDK)

This was referenced Jan 3, 2025
Merged
Merged
Merged
@github-actions github-actions bot added comp:client Related to Client component comp:cli Related to CLI component size:L 100~500 LoC labels Jan 3, 2025
@fregataa Graphite App
Copy link
Member Author

fregataa commented Jan 3, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@fregataa fregataa added this to the 25Q1 milestone Jan 3, 2025
@fregataa fregataa marked this pull request as ready for review January 3, 2025 13:09
@fregataa fregataa force-pushed the topic/01-02-feat_add_per-user_uid_gid_apis branch from e056ec6 to 7614158 Compare January 6, 2025 03:43
@fregataa fregataa force-pushed the topic/01-03-feat_update_sdk_and_cli_to_follow-up_per-user_uid_gid branch from 10fc52d to 9975779 Compare January 6, 2025 03:44
@fregataa fregataa force-pushed the topic/01-02-feat_add_per-user_uid_gid_apis branch from 4f4e9a9 to e70f1cc Compare January 17, 2025 07:16
@fregataa fregataa force-pushed the topic/01-03-feat_update_sdk_and_cli_to_follow-up_per-user_uid_gid branch from 9975779 to cf418f0 Compare January 17, 2025 07:16
@fregataa fregataa force-pushed the topic/01-02-feat_add_per-user_uid_gid_apis branch from ca469e0 to 9660c3e Compare January 21, 2025 02:44
@fregataa fregataa force-pushed the topic/01-03-feat_update_sdk_and_cli_to_follow-up_per-user_uid_gid branch from cf418f0 to bb05310 Compare January 21, 2025 02:45
@fregataa fregataa force-pushed the topic/01-02-feat_add_per-user_uid_gid_apis branch from 9660c3e to 9b5ca7f Compare January 22, 2025 12:21
@fregataa fregataa force-pushed the topic/01-03-feat_update_sdk_and_cli_to_follow-up_per-user_uid_gid branch 2 times, most recently from f1cece1 to 20f5b34 Compare January 24, 2025 06:26
@fregataa fregataa changed the title feat: Update SDK and CLI to follow-up per-user uid/gid feat(BA-530): Update SDK and CLI to follow-up per-user uid/gid Jan 24, 2025
@fregataa fregataa requested a review from HyeockJinKim January 24, 2025 16:21
@fregataa fregataa force-pushed the topic/01-02-feat_add_per-user_uid_gid_apis branch from 33f328b to 46ba1b0 Compare January 24, 2025 16:38
@fregataa fregataa force-pushed the topic/01-03-feat_update_sdk_and_cli_to_follow-up_per-user_uid_gid branch from 20f5b34 to 6d21151 Compare January 24, 2025 16:38
HyeockJinKim
HyeockJinKim reviewed Jan 27, 2025
View reviewed changes
src/ai/backend/client/cli/admin/user.py
help="Unset the user's container primary GID.",
)
@click.option(
"--cgids",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel that abbreviations like cuid and cguid might overlap with other topics.
How about avoiding using abbreviations for now?

@fregataa fregataa force-pushed the topic/01-02-feat_add_per-user_uid_gid_apis branch from 46ba1b0 to 23bca21 Compare February 3, 2025 14:49
@fregataa fregataa force-pushed the topic/01-03-feat_update_sdk_and_cli_to_follow-up_per-user_uid_gid branch from 6d21151 to 9358ed0 Compare February 3, 2025 14:49
@fregataa fregataa force-pushed the topic/01-02-feat_add_per-user_uid_gid_apis branch from 23bca21 to 675bbaf Compare February 5, 2025 09:05
@fregataa fregataa force-pushed the topic/01-03-feat_update_sdk_and_cli_to_follow-up_per-user_uid_gid branch from 9358ed0 to 63ee1a5 Compare February 5, 2025 09:05
HyeockJinKim
HyeockJinKim approved these changes Feb 5, 2025
View reviewed changes
Copy link
Collaborator

@HyeockJinKim HyeockJinKim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now, let’s just keep cuid and cgid as well.

@fregataa fregataa force-pushed the topic/01-02-feat_add_per-user_uid_gid_apis branch from 675bbaf to 4c18c69 Compare February 5, 2025 09:20
@fregataa fregataa force-pushed the topic/01-03-feat_update_sdk_and_cli_to_follow-up_per-user_uid_gid branch from 63ee1a5 to 70ac79b Compare February 5, 2025 09:20
@fregataa fregataa force-pushed the topic/01-02-feat_add_per-user_uid_gid_apis branch from 4c18c69 to 7047355 Compare February 5, 2025 09:52
@fregataa fregataa force-pushed the topic/01-03-feat_update_sdk_and_cli_to_follow-up_per-user_uid_gid branch from 70ac79b to 427da5e Compare February 5, 2025 09:53
@fregataa fregataa force-pushed the topic/01-02-feat_add_per-user_uid_gid_apis branch from 7047355 to 6c4b571 Compare February 5, 2025 10:08
@fregataa fregataa force-pushed the topic/01-03-feat_update_sdk_and_cli_to_follow-up_per-user_uid_gid branch from 427da5e to 163d328 Compare February 5, 2025 10:08
@fregataa fregataa force-pushed the topic/01-02-feat_add_per-user_uid_gid_apis branch from 6c4b571 to 8a23986 Compare February 5, 2025 10:14
@fregataa fregataa force-pushed the topic/01-03-feat_update_sdk_and_cli_to_follow-up_per-user_uid_gid branch from 163d328 to 22d5b7a Compare February 5, 2025 10:14
Base automatically changed from topic/01-02-feat_add_per-user_uid_gid_apis to main February 5, 2025 10:23
@fregataa fregataa force-pushed the topic/01-03-feat_update_sdk_and_cli_to_follow-up_per-user_uid_gid branch from 22d5b7a to ad5b192 Compare February 5, 2025 10:25
@fregataa fregataa added this pull request to the merge queue Feb 5, 2025
Merged via the queue into main with commit 7149f0c Feb 5, 2025
20 of 21 checks passed
@fregataa fregataa deleted the topic/01-03-feat_update_sdk_and_cli_to_follow-up_per-user_uid_gid branch February 5, 2025 10:35
Yaminyam pushed a commit that referenced this pull request Feb 12, 2025
@fregataa @Yaminyam
feat(BA-530): Update SDK and CLI to follow-up per-user uid/gid (#3361)
8ce40c3
Yaminyam pushed a commit that referenced this pull request Feb 12, 2025
@fregataa @Yaminyam
feat(BA-530): Update SDK and CLI to follow-up per-user uid/gid (#3361)
5fe367d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HyeockJinKim HyeockJinKim HyeockJinKim approved these changes

Assignees

@fregataa fregataa

Labels
comp:cli Related to CLI component comp:client Related to Client component size:L 100~500 LoC
Projects
None yet
Milestone
25.6
Development

Successfully merging this pull request may close these issues.

Add per-user UID/GID support to CLI and SDK
2 participants
@fregataa @HyeockJinKim