fix the bug with metatensor.torch.sort
#647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Luthaf
reviewed
Jun 11, 2024
Luthaf
reviewed
Jun 11, 2024
| values=torch.tensor( | ||
| [ | ||
| [1, 2], | ||
| [3, 5], |
There was a problem hiding this comment.
can you remove the last comma on all tensor values? That should reduce a lot the vertical space taken by this code =)
Luthaf
reviewed
Jun 11, 2024
Luthaf
approved these changes
Jun 11, 2024
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #642
Fix the bug with
metatensor.torch.sort#642.The algorithm is not very smart but is constricted by
TorchScript.I also added the test to the torch part
馃摎 Download documentation preview for this pull-request