Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/sort by #644

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Feature/sort by #644

wants to merge 10 commits into from

Conversation

DavideTisi
Copy link
Contributor

@DavideTisi DavideTisi commented Jun 1, 2024 •
edited by github-actions bot
Loading

I added the possibility to sort only by some columns in a specific axis, using name

馃摎 Download documentation preview for this pull-request

@DavideTisi
Copy link
Contributor Author

I open the pr to trigger the CI

@DavideTisi DavideTisi mentioned this pull request Jun 4, 2024
Closed
@DavideTisi DavideTisi marked this pull request as ready for review June 5, 2024 12:09
@DavideTisi
Copy link
Contributor Author

DavideTisi commented Jun 5, 2024 •
edited
Loading

I am opening this PR to understand what we want to do.
This PR has two parts (and it fails in both):

  1. one try to fix metatensor.torch.sort is broken聽#642, @jwa7 example (that I added to the tests) now works, but the torch algo is not a real solution there are other case in which it fails
  2. two the main reason I started this pr. I wanted a "sort by name" function basically instead of sorting everything it sorts following the column with name=name

The main problem is that I do not have a real solution for 1, and I do not have anymore much time to devote to it

@DavideTisi
Copy link
Contributor Author

the questions are:
what do we want to do?
has anyone an idea?

@Luthaf
Copy link
Contributor

Luthaf commented Jun 12, 2024

I think this can be rebased to only contain the sort_by functionality now that #647 is merged.

@DavideTisi
Copy link
Contributor Author

Yes sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@DavideTisi @Luthaf