fix, botreview: handle deleted files in kubevirtci-bump, improve commenting #3124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
kubevirt-bot
added
do-not-merge/work-in-progress
kubevirt-bot
removed
the
do-not-merge/work-in-progress
|
/hold Waiting for #3123 to merge. |
kubevirt-bot
added
the
do-not-merge/hold
dhiller
requested review from
brianmcarey
and removed request for
aglitke,
vladikr and
phoracek
dhiller
changed the title
dhiller
force-pushed
the
improve-review-comment
branch
from
55a285e to
93782d5
Compare
|
@dhiller - is this ready for review? I wasn't sure with the hold in place. |
@brianmcarey thanks for the ping here, I forgot to remove the hold /unhold |
kubevirt-bot
removed
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brianmcarey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
|
/hold need to fix the details section commenting, it doesn't work like this: #3134 (comment) |
kubevirt-bot
added
the
do-not-merge/hold
Previously all files were added as unwanted whenever a review was placed, even if there we no files related to kubevirtci-bump at all in the patch set. Now the review for kubevirtci-bump is only attached if there are relevant files in the PR. Signed-off-by: Daniel Hiller <[email protected]>
Introduce interfaces for faking input and output, create some basic test cases to fix behavior. Signed-off-by: Daniel Hiller <[email protected]>
Move the details of the review into a Markdown details section, so that they do not overflow the comment for the review. Signed-off-by: Daniel Hiller <[email protected]>
Reduce list of files (in case of a very long comment) into a real bullet list. Signed-off-by: Daniel Hiller <[email protected]>
If files are deleted inside the provider bump, this is still ok, so handle file deletions as regular changes. Signed-off-by: Daniel Hiller <[email protected]>
Signed-off-by: Daniel Hiller <[email protected]>
Signed-off-by: Daniel Hiller <[email protected]>
Signed-off-by: Daniel Hiller <[email protected]>
dhiller
force-pushed
the
improve-review-comment
branch
from
93782d5 to
575233d
Compare
|
/unhold |
kubevirt-bot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kubevirtci-bump fixes
Previously all files were added as unwanted whenever a review was placed, even if there we no files related to kubevirtci-bump at all in the patch set.
Now the review for kubevirtci-bump is only attached if there are relevant files in the PR.
Also the handling of deleted files in kubevirtci-bump is fixed.
comment improval
This PR moves files and hunks into a details section so the comment does not overflow the screen.
It also reduces lists of files (in case of a very long comment) into a real bullet list, and also puts it into a details section.
See #3100