Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

botreview, strategy: add kubevirt uploader #3131

Merged
merged 5 commits into from
Jan 13, 2024

Conversation

dhiller
Copy link
Contributor

@dhiller dhiller commented Dec 18, 2023

This PR adds the strategy to review GCS upload PRs for kubevirt/kubevirt.

@kubevirt-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubevirt-bot kubevirt-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Dec 18, 2023
@dhiller dhiller force-pushed the add-kubevirt-uploader branch from 8ba89b2 to daa8464 Compare December 21, 2023 10:59
@kubevirt-bot kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 8, 2024
@dhiller dhiller force-pushed the add-kubevirt-uploader branch from daa8464 to dd8241d Compare January 9, 2024 10:42
@kubevirt-bot kubevirt-bot added size/XL and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL labels Jan 9, 2024
@dhiller
Copy link
Contributor Author

dhiller commented Jan 9, 2024

/uncc @davidvossel
/cc @xpivarc

@kubevirt-bot kubevirt-bot requested review from xpivarc and removed request for davidvossel January 9, 2024 10:51
@dhiller dhiller marked this pull request as ready for review January 9, 2024 10:51
@kubevirt-bot kubevirt-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 9, 2024
@kubevirt-bot kubevirt-bot requested review from enp0s3 and vladikr January 9, 2024 10:51
@dhiller
Copy link
Contributor Author

dhiller commented Jan 9, 2024

/uncc @vladikr

@kubevirt-bot kubevirt-bot removed the request for review from vladikr January 9, 2024 10:52
@dhiller dhiller mentioned this pull request Jan 9, 2024
24 tasks
Copy link
Member

@brianmcarey brianmcarey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

thanks @dhiller !

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 12, 2024
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brianmcarey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 12, 2024
@kubevirt-bot kubevirt-bot merged commit 080d85d into kubevirt:main Jan 13, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants