Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-v0.17] fix: generator of object names #307

Closed
wants to merge 1 commit into from
Closed

[release-v0.17] fix: generator of object names #307

wants to merge 1 commit into from

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #306

/assign ksimon1

NONE

@ksimon1
fix: generator of object names
08b9261 
Sometimes the generator returned the same hash which led to errors in
tests. This commit changes the generator to use the k8s rand package
which will generate hash

Signed-off-by: Karel Simon <[email protected]>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 8, 2024
Merged
@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/XXL labels Jan 8, 2024
@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 8, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 8, 2024

Hi @openshift-cherrypick-robot. Thanks for your PR.

I'm waiting for a kubevirt member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from 0xFelix and akrejcir January 8, 2024 09:41
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 8, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: openshift-cherrypick-robot
Once this PR has been reviewed and has the lgtm label, please assign ksimon1 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ksimon1 ksimon1 closed this Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcanocan jcanocan Awaiting requested review from jcanocan

@lyarwood lyarwood Awaiting requested review from lyarwood

@0xFelix 0xFelix Awaiting requested review from 0xFelix

@akrejcir akrejcir Awaiting requested review from akrejcir

Assignees

@ksimon1 ksimon1

Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@openshift-cherrypick-robot @kubevirt-bot @ksimon1