-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: generator of object names #306
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ksimon1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
1 similar comment
/retest |
This is great! There's still a chance to get collisions. But this should be enough for this purpose. If this is really a problem, consider to increase the number of bytes. |
Sometimes the generator returned the same hash which led to errors in tests. This commit changes the generator to use the k8s rand package which will generate hash Signed-off-by: Karel Simon <[email protected]>
/lgtm |
/cherry-pick release-v0.17 |
@ksimon1: new pull request created: #308 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@ksimon1: new pull request created: #307 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-v0.15 |
@ksimon1: #306 failed to apply on top of branch "release-v0.15":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@ksimon1: #306 failed to apply on top of branch "release-v0.15":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
fix: generator of object names
Sometimes the generator returned the same hash which led to errors in tests. This commit changes the generator to use the remainder after division of random number to generate 5 char hash
Release note: