Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix more compile errors in parsing token kind #37

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 13 additions & 8 deletions crates/hdx_parser/src/traits/declarations.rs
Original file line number Diff line number Diff line change
@@ -1,26 +1,31 @@
use hdx_atom::{atom, Atom};
use hdx_lexer::{Include, Kind, Token};
use hdx_lexer::{Include, Kind};

use crate::{discard, expect, expect_ignore_case, match_ignore_case, parser::Parser, unexpected, Result};
use crate::{discard, expect, expect_ignore_case, parser::Parser, unexpected, Result};

use super::Parse;

pub trait Declaration<'a>: Sized + Parse<'a> {
type DeclarationValue: DeclarationValue<'a>;

fn parse_name(parser: &mut Parser<'a>) -> Result<Atom> {
match parser.next().clone() {
Token::Ident(atom) => {
let token = parser.next();
match token.kind() {
Kind::Ident => {
expect!(parser.next(), Kind::Colon);
Ok(atom.to_ascii_lowercase())
Ok(parser.parse_atom_lower(token))
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the correct way to get a atom from a token ident now?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep! The new Lexer avoids emitting or assigning Atoms until you explicitly call something like parse_atom()/parse_atom_lower(). This lets us skip a bunch of work+memory allocations.

}
token => unexpected!(parser, token),
_ => unexpected!(parser, token),
}
}

fn parse_important(parser: &mut Parser<'a>) -> Result<bool> {
if matches!(parser.peek(), Token::Delim('!'))
&& match_ignore_case!(parser.peek_n(2), Token::Ident(atom!("important")))
let peeked = parser.peek();
let nexted_peek = parser.peek_n(2);
if matches!(peeked.kind(), Kind::Delim)
&& matches!(peeked.char(), Some('!'))
&& matches!(nexted_peek.kind(), Kind::Ident)
&& matches!(parser.parse_atom_lower(*nexted_peek), atom!("important"))
Comment on lines +23 to +28
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this ok? Should this have a macro or is there a better way?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So you should be able to do something like:

Suggested change
let peeked = parser.peek();
let nexted_peek = parser.peek_n(2);
if matches!(peeked.kind(), Kind::Delim)
&& matches!(peeked.char(), Some('!'))
&& matches!(nexted_peek.kind(), Kind::Ident)
&& matches!(parser.parse_atom_lower(*nexted_peek), atom!("important"))
if match_delim!(parser.peek(), Kind::Delim('!'))
&& match_ignore_case!(parser.peek_n(2), Kind::Ident(atom!("important"))

But I think for this to work we'd need to do some work to both the match macros used.

{
parser.advance();
expect_ignore_case!(parser.next_with(Include::all()), Kind::Ident, atom!("important"));
Expand Down
44 changes: 24 additions & 20 deletions crates/hdx_parser/src/traits/rules.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
use hdx_lexer::{Kind, Token};
use hdx_lexer::Kind;

use crate::{discard, expect, parser::Parser, peek, span::Spanned, unexpected, Result, State, Vec};

Expand All @@ -15,8 +15,8 @@ pub trait AtRule<'a>: Sized + Parse<'a> {
// parse_prelude returns an Option, and rules that either require can check
// in parse() or override parse_prelude() to err.
fn parse_prelude(parser: &mut Parser<'a>) -> Result<Option<Spanned<Self::Prelude>>> {
match parser.peek() {
Token::LeftCurly | Token::Semicolon | Token::Eof => Ok(None),
match parser.peek().kind() {
Kind::LeftCurly | Kind::Semicolon | Kind::Eof => Ok(None),
_ => Ok(Some(Self::Prelude::parse_spanned(parser)?)),
}
}
Expand All @@ -25,13 +25,14 @@ pub trait AtRule<'a>: Sized + Parse<'a> {
// one). The default parse_prelude returns an Option, and rules that either
// require can check in parse() or override parse_prelude() to err.
fn parse_block(parser: &mut Parser<'a>) -> Result<Option<Spanned<Self::Block>>> {
match parser.peek() {
Token::Semicolon | Token::Eof => {
let token = parser.peek();
match token.kind() {
Kind::Semicolon | Kind::Eof => {
parser.advance();
Ok(None)
}
Token::LeftCurly => Ok(Some(Self::Block::parse_spanned(parser)?)),
token => unexpected!(parser, token),
Kind::LeftCurly => Ok(Some(Self::Block::parse_spanned(parser)?)),
_ => unexpected!(parser, token),
}
}

Expand Down Expand Up @@ -66,19 +67,21 @@ pub trait QualifiedRule<'a>: Sized + Parse<'a> {

// https://drafts.csswg.org/css-syntax-3/#consume-a-qualified-rule
fn parse_qualified_rule(parser: &mut Parser<'a>) -> Result<(Spanned<Self::Prelude>, Spanned<Self::Block>)> {
match parser.peek().clone() {
token @ Token::Eof => unexpected!(parser, token),
token @ Token::RightCurly if !parser.is(State::Nested) => unexpected!(parser, token),
Token::Ident(atom) if peek!(parser, 2, Kind::RightCurly) && atom.starts_with("--") => {
let token = parser.peek().clone();
match token.kind() {
Kind::Eof => unexpected!(parser, token),
Kind::RightCurly if !parser.is(State::Nested) => unexpected!(parser, token),
Kind::Ident if peek!(parser, 2, Kind::RightCurly) && token.is_dashed_ident() => {
unexpected!(parser);
}
_ => {}
}
let prelude = Self::parse_prelude(parser)?;
match parser.peek().clone() {
token @ Token::Eof => unexpected!(parser, token),
token @ Token::RightCurly if !parser.is(State::Nested) => unexpected!(parser, token),
Token::Ident(atom) if peek!(parser, 2, Kind::RightCurly) && atom.starts_with("--") => {
let token = parser.peek().clone();
match token.kind() {
Kind::Eof => unexpected!(parser, token),
Kind::RightCurly if !parser.is(State::Nested) => unexpected!(parser, token),
Kind::Ident if peek!(parser, 2, Kind::RightCurly) && token.is_dashed_ident() => {
unexpected!(parser);
}
_ => {}
Expand Down Expand Up @@ -116,18 +119,19 @@ pub trait DeclarationRuleList<'a>: Sized + Parse<'a> {
let mut declarations = parser.new_vec();
let mut rules = parser.new_vec();
loop {
match parser.peek() {
Token::AtKeyword(_) => {
let token = parser.peek();
match token.kind() {
Kind::AtKeyword => {
rules.push(Self::AtRule::parse_spanned(parser)?);
}
Token::Ident(_) => {
Kind::Ident => {
declarations.push(Self::Declaration::parse_spanned(parser)?);
}
Token::RightCurly => {
Kind::RightCurly => {
parser.advance();
return Ok((declarations, rules));
}
token => unexpected!(parser, token),
_ => unexpected!(parser, token),
}
}
}
Expand Down
Loading