fix more compile errors in parsing token kind #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koddsson
commented
Jul 28, 2024
| expect!(parser.next(), Kind::Colon); | ||
| Ok(atom.to_ascii_lowercase()) | ||
| Ok(parser.parse_atom_lower(token)) |
There was a problem hiding this comment.
Is this the correct way to get a atom from a token ident now?
There was a problem hiding this comment.
Yep! The new Lexer avoids emitting or assigning Atoms until you explicitly call something like parse_atom()/parse_atom_lower(). This lets us skip a bunch of work+memory allocations.
Comment on lines
+23
to
+28
| let peeked = parser.peek(); | ||
| let nexted_peek = parser.peek_n(2); | ||
| if matches!(peeked.kind(), Kind::Delim) | ||
| && matches!(peeked.char(), Some('!')) | ||
| && matches!(nexted_peek.kind(), Kind::Ident) | ||
| && matches!(parser.parse_atom_lower(*nexted_peek), atom!("important")) |
There was a problem hiding this comment.
Is this ok? Should this have a macro or is there a better way?
There was a problem hiding this comment.
So you should be able to do something like:
Suggested change
| let peeked = parser.peek(); | |
| let nexted_peek = parser.peek_n(2); | |
| if matches!(peeked.kind(), Kind::Delim) | |
| && matches!(peeked.char(), Some('!')) | |
| && matches!(nexted_peek.kind(), Kind::Ident) | |
| && matches!(parser.parse_atom_lower(*nexted_peek), atom!("important")) | |
| if match_delim!(parser.peek(), Kind::Delim('!')) | |
| && match_ignore_case!(parser.peek_n(2), Kind::Ident(atom!("important")) |
But I think for this to work we'd need to do some work to both the match macros used.
keithamus
approved these changes
Jul 28, 2024
keithamus
pushed a commit
that referenced
this pull request
Jul 29, 2024
I messed around some more. Not 100% sure this is the correct way to do this still.
keithamus
pushed a commit
that referenced
this pull request
Oct 23, 2024
I messed around some more. Not 100% sure this is the correct way to do this still.
keithamus
pushed a commit
that referenced
this pull request
Oct 27, 2024
I messed around some more. Not 100% sure this is the correct way to do this still.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I messed around some more. Not 100% sure this is the correct way to do this still.