Revert "Switch to using repo2docker with buildkit for building" #3228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuvipanda
added a commit
to yuvipanda/mybinder.org-deploy
that referenced
this pull request
Feb 18, 2025
The reason we had to revert jupyterhub#3228 was that the image cache was growing big, and so was the buildkit cache. So this meant images were being stored in *three* places: 1. the buildkit cache (dind) 2. the image cache (dind) 3. the containerd store (by kubernetes, when it pulls) 1 and 2 were both set to about 300, so this caused the disk to fill up. Here, I more aggressively prune the image cache, as it is simply not used when buildkit is used. Once I verify this works ok, I'll turn on buildkit building again and we see how it goes.
This was referenced Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #3225
We were running out of disk space, causing issues: https://jupyter.zulipchat.com/#narrow/channel/469744-jupyterhub/topic/mybinder.2Eorg.20outage