Skip to content

Commit

Permalink
hetzner: Run imagecleaner more aggressively
Browse files Browse the repository at this point in the history
The reason we had to revert jupyterhub#3228
was that the image cache was growing big, and so was the buildkit
cache. So this meant images were being stored in *three* places:

1. the buildkit cache (dind)
2. the image cache (dind)
3. the containerd store (by kubernetes, when it pulls)

1 and 2 were both set to about 300, so this caused the disk to
fill up.

Here, I more aggressively prune the image cache, as it is simply
not used when buildkit is used. Once I verify this works ok, I'll
turn on buildkit building again and we see how it goes.
  • Loading branch information
yuvipanda committed Feb 18, 2025
1 parent 014e118 commit ca8663b
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 25 deletions.
7 changes: 0 additions & 7 deletions config/curvenote.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -188,13 +188,6 @@ binderhub:
# # maxAge: 1 hour since we're just testing
# maxAge: 3600

imageCleaner:
# TODO: priorityClassName: binderhub-core
enabled: true
# Use 40GB as upper limit, size is given in bytes
imageGCThresholdHigh: 40e9
imageGCThresholdLow: 30e9
imageGCThresholdType: "absolute"

cryptnono:
enabled: true
Expand Down
8 changes: 0 additions & 8 deletions config/hetzner-2i2c-bare.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -103,14 +103,6 @@ binderhub:
hosts:
- hub.2i2c-bare.mybinder.org

imageCleaner:
# Use 300GB as upper limit, size is given in bytes
imageGCThresholdHigh: 300e9
imageGCThresholdLow: 100e9
imageGCThresholdType: "absolute"
# don't cordon single-node cluster while cleaning
cordon: false

grafana:
ingress:
hosts:
Expand Down
4 changes: 0 additions & 4 deletions config/hetzner-2i2c.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -97,10 +97,6 @@ binderhub:
- hub.2i2c.mybinder.org

imageCleaner:
# Use 300GB as upper limit, size is given in bytes
imageGCThresholdHigh: 300e9
imageGCThresholdLow: 100e9
imageGCThresholdType: "absolute"
# don't cordon single-node cluster while cleaning
cordon: false

Expand Down
6 changes: 0 additions & 6 deletions config/ovh2.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -85,12 +85,6 @@ binderhub:
userScheduler:
nodeSelector: *coreNodeSelector

imageCleaner:
# Use 40GB as upper limit, size is given in bytes
imageGCThresholdHigh: 40e9
imageGCThresholdLow: 30e9
imageGCThresholdType: "absolute"

grafana:
nodeSelector: *coreNodeSelector
ingress:
Expand Down

0 comments on commit ca8663b

Please sign in to comment.