minimize overhead when checking the supported args by RStudio #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 3, 2025
yuvipanda
approved these changes
Jan 3, 2025
3 tasks
|
yay, thank you @jhgoebbert! I tested this and it seems fine. I really appreciate your patience in getting these through. Looking forward to more PRs from you in the future! \o/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code ensures that
rstudio --helpis only called once which reduces the startup-overhead.The function
_support_args(..)returns a dict with true/false for all arguments passed as input. This dict is then checked afterwards if certain arguments are supported or not. So, if you want to check for a new arg now you must add it to_support_args(..)'s input-list first.This PR also adds support for setting
www-thread-pool-sizevia the environment variableJUPYTER_RSESSION_PROXY_THREAD_POOL_SIZE.