-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support communicating with rstudio via unix socket instead of tcp socket #159
Conversation
Excellent @jhgoebbert! The code looks good to me, am spinning up my local test env and will merge once I can verify it. Thank you so much for your patience! |
This allows us to default to using unix sockets by default in the future once this feature is better tested, and allow people to turn it off if needed.
@jhgoebbert ok, tested this and it looks fine! I have one suggestion that I made as a PR to your repo: jhgoebbert#1. If that seems ok to you, and you merge that, I'm happy to merge this PR! |
This is the Dockerfile I used for testing:
Then I build it with Then I could run it like |
Explicitly check for 'no' and 'false' in USE_SOCKET env var
Thank you very very much, @jhgoebbert! Would love a PR with the rest of your initial contribution too! |
Thank you for merging this, @yuvipanda |
@jhgoebbert I opened #161 to turn this feature on by default! |
Thanks to @sgibson91 there is a new release out now! |
This PR only adds the part for unix-socket-support from #151 as @yuvipanda asked in #151 (comment) to better split it.
It enables RStudio connections via sockets in combination with this PR for RStudio rstudio/rstudio#14938 which is part of the official release RStudio v2024.12.0+467.