🎨 Update CSS classes applied to math nodes to match remark-math

[sglyon]

change math block to math-display and math inline to math-inline

ref #859

[welcome]

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.

Welcome to the EBP community! 🎉

[sglyon]

I'm working on fixing some tests right now! Will ping when ready!

[sglyon]

@rowanc1 ok I think we are about ready to go.

I added some very simple tests to myst-to-html

It seems like myst-parser gets some tests based on the examples in the myst-spec package. I make a related PR over there to update the class names: jupyter-book/myst-spec#63

So, if we are able to merge/release myst-spec and then update the dependency over here the tests should pass ;)

[rowanc1]

Thanks so much for this work @sglyon.

A question @agoose77 had this morning was ensuring that we don't need to also add $$ or \[ or other text delimiters into the output? Do you have knowledge of if that will be desirable/necessary in the remark/rehype pipelines?

[rowanc1]

So many changes for a -!! 🚀 Thanks again @sglyon for your help on this.

[sglyon]

Hey @rowanc1 I don't think it will be necessary because of how the ast looks, but I don't know for sure...

From what I can tell by the tests over there I thiknk we will be good without adding additional characters: https://github.com/remarkjs/remark-math/blob/e99b9d088709d743adf6a43551fd416d7e0014ed/packages/rehype-katex/test.js#L27-L47

[rowanc1]

Fantastic! Thank you, will get this in shortly!! (Away from my keyboard now..)

[welcome]

Congrats on your first merged pull request in this project! 🎉


Thank you for contributing, we are very proud of you! ❤️

[rowanc1]

Thanks again @sglyon for your help in tracking these down and improving them in various repos!

[sglyon]

Awesome!! looking forward to a release and I'll test it out in my app ;)

[sglyon]

@rowanc1 could we get a new build out for myst-to-html? Then I can start using 👏

[rowanc1]

We are planning on releasing later today!

[rowanc1]

Version 1.0.22 should now be out! Thanks again for your help.

[sglyon]

Amazing — thank you!

On January 29, 2024, Spencer Lyon ***@***.***> wrote: Version 1.0.22 should now be out! Thanks again for your help.

— Reply to this email directly, view it on GitHub <#862 (comment) 1915822159>, or unsubscribe <https://github.com/notifications/unsubscribe- auth/AAHUTXHVTJR2ROYGG7CGINDYRA4ZDAVCNFSM6AAAAABCFDFIPGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJVHAZDEMJVHE>. You are receiving this because you were mentioned.Message ID: ***@***.***>