Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update classes applied to html math output #63

Merged
merged 2 commits into from
Jan 24, 2024
Merged

update classes applied to html math output #63

merged 2 commits into from
Jan 24, 2024

Conversation

sglyon
Copy link
Contributor

@sglyon sglyon commented Jan 22, 2024

@rowanc1 This goes along with jupyter-book/mystmd#862

@welcome Welcome
Copy link

welcome bot commented Jan 22, 2024

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.

Welcome to the EBP community! 🎉

@sglyon sglyon mentioned this pull request Jan 22, 2024
Merged
fwkoch
fwkoch approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@fwkoch fwkoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for hunting down these test cases. It is not very intuitive (nor nice to work with) that mystmd is dependent on these - certainly something to improve...

But for now, this is great, and we can just merge as soon as your other PR in mystmd is ready to go!

rowanc1
rowanc1 approved these changes Jan 24, 2024
View reviewed changes
Copy link
Member

@rowanc1 rowanc1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sglyon - this is great and aligns this choice with the wider unified ecosystem. These were arbitrary choices that are now no longer arbitrary! Excited to see better integrations with the rehype/remark community as we make these sorts of changes.

@rowanc1 rowanc1 merged commit f07f9e9 into jupyter-book:main Jan 24, 2024
3 checks passed
@welcome Welcome
Copy link

welcome bot commented Jan 24, 2024

Congrats on your first merged pull request in this project! 🎉
congrats

Thank you for contributing, we are very proud of you! ❤️

@sglyon
Copy link
Contributor Author

sglyon commented Jan 24, 2024

Awesome thanks team!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rowanc1 rowanc1 rowanc1 approved these changes

@fwkoch fwkoch fwkoch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sglyon @rowanc1 @fwkoch