Skip to content

Defer hiding the attached session until after duplicates have been hidden #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joshmedeski merged 3 commits into from
Nov 6, 2025
Merged

Defer hiding the attached session until after duplicates have been hidden #250

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c6d1c43
Modernize with slices.Delete
markjaquith Apr 24, 2025
b15cb14
Defer hiding the attached session until after its duplicates have been
markjaquith Apr 24, 2025
cd04dc6
Merge branch 'main' into issue/249/hide-duplicates-and-hide-attached-bug
joshmedeski Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 11 additions & 10 deletions lister/list.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package lister

import (
"github.com/joshmedeski/sesh/v2/model"
"slices"
)

type (
Expand Down Expand Up @@ -37,16 +38,6 @@ func (l *RealLister) List(opts ListOptions) (model.SeshSessions, error) {
if err != nil {
return model.SeshSessions{}, err
}
if opts.HideAttached {
attachedSession, _ := GetAttachedTmuxSession(l)
sessionsCopy := sessions.OrderedIndex
for i, ses := range sessionsCopy {
if attachedSession.Name == sessions.Directory[ses].Name {
sessions.OrderedIndex = append(sessions.OrderedIndex[:i],
sessions.OrderedIndex[i+1:]...)
}
}
}
fullOrderedIndex = append(fullOrderedIndex, sessions.OrderedIndex...)
for _, i := range sessions.OrderedIndex {
fullDirectory[i] = sessions.Directory[i]
Expand All @@ -71,6 +62,16 @@ func (l *RealLister) List(opts ListOptions) (model.SeshSessions, error) {
fullOrderedIndex = fullOrderedIndex[:destIndex]
}

if opts.HideAttached {
attachedSession, _ := GetAttachedTmuxSession(l)
for i, index := range fullOrderedIndex {
if fullDirectory[index].Name == attachedSession.Name {
fullOrderedIndex = slices.Delete(fullOrderedIndex, i, i+1)
break
Copy link
Contributor Author

@markjaquith markjaquith Apr 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Does it seem right to break here? Is it possible to have two sessions with the same .Name?
  2. If it's not possible to have two sessions with the same .Name, isn't the active session always first in the list? So Couldn't I skip the iteration and just check fullDirectory[fullOrderedIndex[0]].Name against attachedSession.Name to save a bunch of CPU cycles?

}
}
}

return model.SeshSessions{
OrderedIndex: fullOrderedIndex,
Directory: fullDirectory,
Expand Down