Defer hiding the attached session until after duplicates have been hidden

[markjaquith]

fixes #249

Warning

Be gentle: this is the first Go code I've written

Note

Using slices.Delete was recommended by the linter as the modern way, versus slicing around the range you want to delete, so I went with that.

[markjaquith]

1. Does it seem right to break here? Is it possible to have two sessions with the same .Name?
2. If it's not possible to have two sessions with the same .Name, isn't the active session always first in the list? So Couldn't I skip the iteration and just check fullDirectory[fullOrderedIndex[0]].Name against attachedSession.Name to save a bunch of CPU cycles?

[joshmedeski]

Some related code got merged recently, can you confirm that main still has the same issue?

[joshmedeski]

@markjaquith flagging this again. A bit has been merged, can you confirm the issue is still present?

[joshmedeski]

Hey @markjaquith are you still seeing this issue?

[markjaquith]

I created /tmp/foo and then created a session in that dir. Seems like the issue still exists.

 ❯ pwd
/tmp/foo
 ❯ sesh list | grep foo
foo
/tmp/foo
 ❯ sesh list --hide-duplicates | grep foo
foo
 ❯ sesh list --hide-attached | grep foo
/tmp/foo
 ❯ sesh list --hide-attached --hide-duplicates | grep foo
/tmp/foo

I still think that if I'm hiding the attached and also hiding duplicates, that every duplicate of the attached session directory should be hidden. What I'm trying to accomplish is:

1. I don't want to see my active session anywhere in the list.
2. I want each directory to appear a maximum of once... if there is a session for it, it should show there. If not, and there is a config, then in config. If there is not a session or a config, then in zoxide list.

[joshmedeski]

Thanks for the feedback, does this PR confirm it fixes it?

[joshmedeski]

I manually tested this and it appears to be working as expected, thanks!