Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved code readbility for hosting checks #4023

Draft
wants to merge 10 commits into
base: master
Choose a base branch
from
Draft

Improved code readbility for hosting checks #4023

wants to merge 10 commits into from

Commits on Jul 27, 2024

  1. Implement new handling of condition that checks if the pom file exists

    @TheMeinerLP
    TheMeinerLP committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    83562d8 View commit details
    Browse the repository at this point in the history

  2. Move model classes into extra package for better overview. 

    That's also include a transformation of calls into a java record class
    @TheMeinerLP
    TheMeinerLP committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    6ff8676 View commit details
    Browse the repository at this point in the history

  3. Convert old verifier into bi-consumer verifier. 

    Java has some function interfaces that can the same and java 21 has some smart casts to handle some extra functionality
    @TheMeinerLP
    TheMeinerLP committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    8b5bdcc View commit details
    Browse the repository at this point in the history

  4. Use the new classes instead of old one

    @TheMeinerLP
    TheMeinerLP committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    e3c13e8 View commit details
    Browse the repository at this point in the history

  5. Cleanup old classes

    @TheMeinerLP
    TheMeinerLP committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    062238f View commit details
    Browse the repository at this point in the history

  6. Add resource bundle instead of plain strings

    @TheMeinerLP
    TheMeinerLP committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    0ac7e74 View commit details
    Browse the repository at this point in the history

  7. Use resource bundles

    @TheMeinerLP
    TheMeinerLP committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    19063ba View commit details
    Browse the repository at this point in the history

  8. Reduce complexity

    @TheMeinerLP
    TheMeinerLP committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    e095843 View commit details
    Browse the repository at this point in the history

  9. Transfer JenkinsProjectUserVerifierConsumer message into resource bundle

    @TheMeinerLP
    TheMeinerLP committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    86a4860 View commit details
    Browse the repository at this point in the history

  10. Transfer some MavenVerifierConsumer,GitHubVerifierConsumer,HostingFie… 

    …ldVerifierConsumer,HostingChecker message into resource bundle
    @TheMeinerLP
    TheMeinerLP committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    a194ee0 View commit details
    Browse the repository at this point in the history