Improved code readbility for hosting checks #4023
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That's also include a transformation of calls into a java record class
Java has some function interfaces that can the same and java 21 has some smart casts to handle some extra functionality
…ldVerifierConsumer,HostingChecker message into resource bundle
timja
reviewed
Jul 27, 2024
|
|
||
| // check list of users | ||
| if (users.isEmpty()) { | ||
| hostingIssues.add(new VerificationMessage(VerificationMessage.Severity.REQUIRED, HostingConfig.RESOURCE_BUNDLE.getString("MISSING_LIST_OF_USERS"))); |
There was a problem hiding this comment.
what's the reasoning for this? we aren't likely to internationalise these so imo its just adding a layer of indirection.
Also I suspect a number of the messages are missing escaping for e.g. ' in a number of places its adding complexity
There was a problem hiding this comment.
The boiler code that may affect the readability of other developers, especially the messages, was simply moved to a file. With Intellij I can jump from string to resource bundle and back again, the complexity is reduced in this case with the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up code and changes existing code to Java 21 functions to make it more readable. Code optimizations and readability improvements were attempted.
Unfortunately I am not able to test this because I am still working my way through it