Fix copyrights and other clean up #1345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottmarlow
reviewed
Jun 28, 2024
| Nov 21, 2000<br> | ||
| 3:45:02 AM<br> | ||
| Nov 21, 2000, 3:45:02 AM<br> | ||
| Nov 21, 2000, 3:45:02 AM<br> |
There was a problem hiding this comment.
@pnicolucci did you intend to update line 19 of jstl/src/main/resources/com/sun/ts/tests/jstl/spec/fmt/format/parsedate/positivePDFallbackLocaleTestJava20Plus.gf?
There was a problem hiding this comment.
Yes, I did as it was a standard space and not a NNBSP as it should have been for Java 20+
|
https://www.eclipse.org/projects/handbook/#ip-copyright-headers is a good reference as well and that mentions the |
starksm64
pushed a commit
to jakartaredhat/platform-tck-refactor
that referenced
this pull request
Jul 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue
This is a clean up PR for: #1329
Related Issue(s)
N/A
Describe the change
Some Oracle copyrights were modified from
Copyright (c) 2003, 20xx Oracle and/or its affiliates. All rights reserved.toCopyright (c) 2003 Contributors to the Eclipse Foundationwhich is incorrect and the following should just be added:Copyright (c) 2024 Contributors to the Eclipse FoundationThe Oracle copyrights should be preserved.The new JSPs that were added as part of the original PR I made are copies of the existing JSPs with minor updates, as such the original Oracle copyright should be maintained, so I've added that back as well.
Eclipse copyright policy: https://www.eclipse.org/projects/handbook/#legaldoc-faq
Some of the space characters in the new JSPs were incorrect. I updated these.
I updated all the files that were different from the original PR to ensure consistent content between the JSP files.
Additional context
CC @alwin-joseph @scottmarlow