JSTL Test Fix(tckrefactor branch) for issues/255 in JDK21 due to space character before AM/PM #1329
Conversation
jstl/src/main/java/com/sun/ts/tests/jstl/common/client/AbstractUrlClient.java
Outdated
Show resolved
Hide resolved
| <%-- | ||
|
|
||
| Copyright (c) 2003 Contributors to the Eclipse Foundation | ||
|
|
There was a problem hiding this comment.
There are files in https://github.com/jakartaee/platform-tck/pull/1320/files#diff-4254e4814daa576f775cd40e835a7e0eca3da9be2b6bd679fcc13be9901fdb94 where I added a new copyright:
Copyright (c) 2024 Contributors to the Eclipse Foundation
We should preserve that here since we're just copying that code to a different branch.
There was a problem hiding this comment.
I won't comment on each file but my comment applies to more than just this file.
There was a problem hiding this comment.
I corrected copyrights of the new files added.
There was a problem hiding this comment.
@alwin-joseph shouldn't the Oracle copyright be preserved? Then just the new copyright holder added to the header? https://www.eclipse.org/projects/handbook/#legaldoc-faq. See https://github.com/jakartaee/platform-tck/pull/1320/files#diff-4254e4814daa576f775cd40e835a7e0eca3da9be2b6bd679fcc13be9901fdb94R4 for an example.
There was a problem hiding this comment.
I created a new PR here with some cleanup :#1345
…e character before AM/PM (jakartaee#1329) * JSTL Test fix in JDK21 due to space character before AM/PM * correct copyrights * correct copyrights for new files, as per review
Related Issue(s)
Describe the change
Copied the changes from #1320 to fix the refactored JSTL tests to pass in JDK21
To run the jstl tck and test the fix with Glassfish :
cd $WORKSPACE/jstl; mvn clean install: To install the refactored jstl tckcd $WORKSPACE/glassfish-runner/jstl-tck; mvn clean verify: To run the jstl tck with Glassfish 8.0.0-M5(JDK21)cc @pnicolucci