Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebase to current and requested modifications #4

Merged
merged 817 commits into from
Aug 16, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
817 commits
Select commit Hold shift + click to select a range
c87de6b
always get progress events
minrk Sep 24, 2021
5c5e6b1
use Future to wait for ready event
minrk Sep 24, 2021
3af0092
streaming callback shouldn't be async
minrk Sep 30, 2021
a211198
Merge pull request #1393 from minrk/launchmessages
consideRatio Sep 30, 2021
c539a31
Update Versioneer to 0.20
manics Sep 30, 2021
e09e069
Merge pull request #1401 from manics/versioneer
betatim Oct 1, 2021
5c0f130
Switch to jupyter-packaging for npm js
manics Oct 1, 2021
ced3e65
Add missing files to MANIFEST.in
manics Oct 1, 2021
f2cd428
Support PEP 518 build
manics Oct 1, 2021
ebe9236
Update publish workflow to check pypi build
manics Oct 1, 2021
0ceb746
PEP518 build in binderhub/Dockerfile
manics Oct 1, 2021
784a83f
Update CONTRIBUTING.md
manics Oct 1, 2021
1da7538
Manually create the launch URL instead of using the response from JHub
MridulS Oct 1, 2021
bb9a777
Merge pull request #1400 from manics/jupyter-packaging
consideRatio Oct 1, 2021
b6f2cac
Test latest (1.22) and oldest supported and testable (1.18) k8s version
consideRatio Oct 5, 2021
92fc291
use hub/api/health endpoint
minrk Oct 5, 2021
d0d725c
Merge pull request #1406 from minrk/api-health
consideRatio Oct 5, 2021
2d03d99
Merge pull request #1402 from MridulS/emit_events_debug
minrk Oct 6, 2021
2a9ace3
Implement LocalRepo2dockerBuild.stop()
manics Sep 13, 2021
5a54586
Test LocalRepo2dockerBuild.stop
manics Sep 13, 2021
1f743b3
test_local_repo2docker_build_stop needs a slow build
manics Oct 6, 2021
bd49846
_execute_cmd stop ASAP
manics Oct 6, 2021
ee78c16
Merge pull request #1392 from consideRatio/pr/test-against-k8s-1.22
consideRatio Oct 7, 2021
10b6c9a
helm-chart: update ingress resource for k8s 1.22+
consideRatio Oct 5, 2021
2a3930b
helm-chart: update ingress schema and default values
consideRatio Oct 5, 2021
04b38fe
ci: stop running scheduled CodeQL jobs that never fail
consideRatio Oct 5, 2021
170fc86
Merge pull request #1405 from consideRatio/pr/no-longer-opt-in-to-sch…
consideRatio Oct 7, 2021
ee9ed7f
Merge pull request #1407 from consideRatio/pr/bump-and-fix-ingress
consideRatio Oct 7, 2021
4b531bd
helm-chart: fix failure to omit ingress.hosts
consideRatio Oct 5, 2021
94183ea
Merge pull request #1391 from consideRatio/pr/use-external-image-cleaner
consideRatio Oct 7, 2021
d2c7b79
helm-chart: support modern api-version of PDBs
consideRatio Oct 7, 2021
016b8f5
pycurl is optional
manics Oct 9, 2021
6cd0cfb
Add pycurl to dev-requirements.txt
manics Oct 9, 2021
8f754dd
Fix typo configuring use of github api token
consideRatio Oct 10, 2021
1ee60f4
helm-chart: fix typo for new Ingress apiVersion format
consideRatio Oct 10, 2021
a56274d
Merge pull request #1416 from consideRatio/pr/fix-typo
consideRatio Oct 10, 2021
6339b8e
Merge pull request #1411 from consideRatio/pr/handle-no-host
consideRatio Oct 10, 2021
9e1a870
Merge pull request #1412 from consideRatio/pr/bump-pdbs-api-version
consideRatio Oct 10, 2021
be93309
helm-chart/ci: test creation of ingress and dind k8s resources
consideRatio Oct 10, 2021
034d0f2
helm-chart: fix image-cleaner command, rely on default startup command
consideRatio Oct 10, 2021
abdb8c8
helm-chart: bump to use image cleaner alpha.2
consideRatio Oct 10, 2021
c42efb8
ci: make await_binderhub smarter
consideRatio Oct 10, 2021
2f07e0f
Merge pull request #1417 from consideRatio/pr/test-creation-of-k8s-re…
consideRatio Oct 10, 2021
45c2644
helm-chart: consistent use of with
consideRatio Oct 10, 2021
b6aa954
helm-chart: don't use trimSuffix after toYaml, not needed
consideRatio Oct 10, 2021
edfb641
helm-chart/ci: create an upgrade test
consideRatio Oct 10, 2021
c1a297a
Merge pull request #1420 from consideRatio/pr/ci-add-upgrade-test
consideRatio Oct 10, 2021
63e5542
helm-chart: fix pdb not accepting maxUnavailable
consideRatio Oct 10, 2021
d61fb4b
helm-chart: default to 1 maxUnavailable rather than 1 minAvailable
consideRatio Oct 10, 2021
0cdc261
image: use tini to react on SIGTERM for quick terminations
consideRatio Oct 10, 2021
3e41ced
ci: stop using --long as chartpress 1.0.0 makes it not needed
consideRatio Oct 10, 2021
a5de2b0
image: build for arm64 as well
consideRatio Oct 10, 2021
7b68a52
image: build ruamel.yaml.clib wheel as well for arm64
consideRatio Oct 11, 2021
2567057
image: refreeze dependencies
consideRatio Oct 11, 2021
b1924ca
Merge pull request #1423 from consideRatio/pr/refreeze-dependencies
minrk Oct 11, 2021
1079c75
Merge branch 'master' into pr/fix-github-api-token-typo
minrk Oct 11, 2021
674e79b
Merge pull request #1418 from consideRatio/pr/fix-pdb-failure
minrk Oct 11, 2021
a303070
Merge pull request #1421 from consideRatio/pr/use-tini-react-on-sigterm
minrk Oct 11, 2021
a010f18
Merge pull request #1422 from consideRatio/pr/build-for-arm64
minrk Oct 11, 2021
f8a9d7a
Merge pull request #1419 from consideRatio/pr/refactor-templates
minrk Oct 11, 2021
ce0bb85
Fix typo configuring use of github api token (#1415)
minrk Oct 11, 2021
cc57b24
Merge pull request #1413 from manics/pycurl-optional
consideRatio Oct 18, 2021
f9ff26f
Fix typo
yuvipanda Oct 21, 2021
2a7904d
Merge pull request #1426 from jupyterhub/yuvipanda-patch-1
manics Oct 21, 2021
6fcf3e2
Use snakecase, explain _execute_cmd sync/async
manics Oct 26, 2021
3c21109
Remove extra debug print in test_build.py
manics Oct 26, 2021
b53a24d
remove custom `dependencies` script in place of plain pip-compile
minrk Nov 12, 2021
4ff3920
move pip-compile explanation to a README for the image
minrk Nov 15, 2021
39a9e38
only record response if there is one
minrk Nov 15, 2021
3b5c384
Merge pull request #1434 from minrk/record-none
consideRatio Nov 15, 2021
7c39292
Merge pull request #1433 from minrk/plain-pip-compile
yuvipanda Nov 18, 2021
760c428
LocalRepo2dockerBuild.stop: read by line
manics Nov 19, 2021
87d8f20
Use monotonic instead of time for test intervals
manics Nov 19, 2021
013c491
Merge pull request #1410 from manics/build-local-r2d-stop
minrk Nov 23, 2021
9fa2747
enforce overall pod quota on attempts to launch
minrk Dec 21, 2021
40b1cc6
Merge pull request #1441 from minrk/enforce-quota
consideRatio Dec 21, 2021
f7c9615
add quota rejections to launch count metric
minrk Dec 22, 2021
47dc681
Merge pull request #1442 from minrk/quota-prometheus
betatim Dec 22, 2021
4e75de4
Bump version of docker used in image builder
yuvipanda Jan 19, 2022
538a156
Merge pull request #1446 from yuvipanda/bump-docker
consideRatio Jan 19, 2022
48bc0f6
update"path to a notebook" text for pathType=lab
minrk Nov 3, 2021
7621c5f
Merge pull request #1428 from minrk/pathtype-text
minrk Jan 26, 2022
3d61c7a
Update Turing Way's Zero-to-Binder link
sgibson91 Feb 7, 2022
f0671c1
Merge pull request #1449 from jupyterhub/sgibson91-patch-1
consideRatio Feb 7, 2022
a4f2feb
build(deps): bump jupyterhub in /helm-chart/images/binderhub
dependabot[bot] Feb 12, 2022
550118e
Merge pull request #1430 from jupyterhub/dependabot/pip/helm-chart/im…
dependabot[bot] Feb 12, 2022
b27ab82
repo2docker 2022.02.0
manics Feb 14, 2022
63c27b3
Fix broken link to Chart.yaml referenced logo
consideRatio Feb 26, 2022
6d4f19b
Merge pull request #1456 from consideRatio/pr/update-chart-logo
manics Feb 26, 2022
b10a3d7
Merge pull request #1451 from manics/bump-r2d
minrk Mar 3, 2022
8da69f2
fix total pod count
minrk Mar 3, 2022
98940b2
Merge pull request #1457 from minrk/pod-quota
minrk Mar 3, 2022
bcebf81
reverse generated-python direction
minrk Mar 8, 2022
a9ff870
check_embedded_chart_code has Python dependencies
minrk Mar 8, 2022
d19a36a
ensure pycurl is available in image
minrk Mar 9, 2022
3ccb21a
Merge pull request #1462 from minrk/libcurl
consideRatio Mar 9, 2022
763bb4e
Remove typo in helm chart schema.yaml
consideRatio Mar 9, 2022
61dd85d
helm chart: add global to schema
consideRatio Mar 9, 2022
31a423f
Add pre-commit config
consideRatio Sep 20, 2021
0849f59
Add minimal flake8 config from black docs
consideRatio Sep 20, 2021
5740da6
Add .prettierignore to omit helm templates
consideRatio Sep 20, 2021
e2295ee
Please flake8 by removing unused variable
consideRatio Mar 25, 2022
4169712
Merge pull request #1381 from consideRatio/pr/pre-commit
consideRatio Mar 29, 2022
ef354c0
Merge pull request #1459 from minrk/reverse-generated-spawner
manics Mar 29, 2022
ed38d15
pre-commit: use isort instead of reorder-python-imports
consideRatio Apr 1, 2022
e3afb29
pre-commit: add hook to update script generated code in values.yaml
consideRatio Apr 1, 2022
f5c32d0
pre-commit: manually please flake8, remove unused variables
consideRatio Mar 30, 2022
24da4e5
pre-commit: run pyupgrade
consideRatio Apr 1, 2022
bb047d8
pre-commit: run black
consideRatio Apr 1, 2022
f0fe025
pre-commit: run isort
consideRatio Apr 1, 2022
d32e9ef
pre-commit: run update-values-based-on-bindarspawner-mixin
consideRatio Apr 1, 2022
9fefdc4
pre-commit: run prettier
consideRatio Apr 1, 2022
b815163
pre-commit: run end-of-file-fixer
consideRatio Apr 1, 2022
da40927
pre-commit: run requirements-txt-fixer
consideRatio Apr 1, 2022
4be7f2e
Add .git-blame-ignore-revs file to avoid cluttering git blame
consideRatio Mar 30, 2022
a9e2bc8
docs: fix outdated comment
consideRatio Apr 1, 2022
656204b
Merge pull request #1465 from consideRatio/pr/pre-commit-run
minrk Apr 1, 2022
3d3e24e
Merge pull request #1463 from consideRatio/pr/fix-schema-typo
consideRatio Apr 1, 2022
9f6ed24
[pre-commit.ci] pre-commit autoupdate
pre-commit-ci[bot] Apr 4, 2022
beeef36
Merge pull request #1467 from jupyterhub/pre-commit-ci-update-config
consideRatio Apr 4, 2022
91f125d
pre-commit: fix pre-commit.ci failure by declaring ruamel.yaml as dep
consideRatio Apr 5, 2022
73c7339
Merge pull request #1468 from consideRatio/pr/fix-pre-commit-ruamel-y…
minrk Apr 6, 2022
3a6637a
[pre-commit.ci] pre-commit autoupdate
pre-commit-ci[bot] Apr 11, 2022
26df09a
Merge pull request #1470 from jupyterhub/pre-commit-ci-update-config
consideRatio Apr 13, 2022
150b648
Reduce complexity by merging configmap/secret into secret
consideRatio Oct 29, 2020
9968e23
Retain old behaviour to only restart on relevant config changes
consideRatio Dec 11, 2020
51b7354
Update helm-chart/binderhub/templates/deployment.yaml
manics Apr 23, 2022
66ca304
Merge pull request #1179 from consideRatio/pr/merge-config-sources
consideRatio Apr 23, 2022
f0db8e4
support custom templates via helm
minrk Apr 25, 2022
d92f718
workaround CI installing same config against different schemas
minrk Apr 25, 2022
fa071b4
import extraFiles wholesale from z2jh
minrk Apr 25, 2022
e87e25a
add test for custom template
minrk Apr 26, 2022
0b49d3a
Merge pull request #1472 from minrk/helm-templates
minrk Apr 27, 2022
0fff0a4
[pre-commit.ci] pre-commit autoupdate
pre-commit-ci[bot] May 9, 2022
fe2ff6b
Merge pull request #1474 from jupyterhub/pre-commit-ci-update-config
consideRatio May 10, 2022
6f9c659
ci: add workflow to bump helm chart image dependencies
consideRatio May 25, 2022
f65f60b
ci: add dependabot to update github actions
consideRatio May 25, 2022
904ff0e
Bump docker-image-cleaner to 1.0.0-beta.1
consideRatio May 25, 2022
f56aee9
Merge pull request #1479 from consideRatio/pr/add-dependabot-config
consideRatio May 25, 2022
f497d47
build(deps): bump actions/setup-node from 2.pre.beta to 3.2.0
dependabot[bot] May 25, 2022
e7392ed
build(deps): bump codecov/codecov-action from 1 to 3
dependabot[bot] May 25, 2022
018e9a2
build(deps): bump actions/cache from 2 to 3
dependabot[bot] May 25, 2022
da23165
build(deps): bump actions/checkout from 2 to 3
dependabot[bot] May 25, 2022
a762216
build(deps): bump docker/setup-buildx-action from 1.6.0 to 2
dependabot[bot] May 25, 2022
b925fd8
docs: prefer use of https over http
consideRatio May 25, 2022
8372e23
Apply suggestions from code review
consideRatio May 25, 2022
7212b05
Merge pull request #1486 from jupyterhub/dependabot/github_actions/do…
consideRatio May 25, 2022
e4f8ef5
Merge pull request #1485 from jupyterhub/dependabot/github_actions/ac…
consideRatio May 25, 2022
e6f6058
Merge pull request #1484 from jupyterhub/dependabot/github_actions/ac…
consideRatio May 25, 2022
b8a03a0
Merge pull request #1482 from jupyterhub/dependabot/github_actions/ac…
consideRatio May 25, 2022
b15cf9a
Merge pull request #1481 from consideRatio/pr/use-https-when-possible
consideRatio May 25, 2022
81017b4
Merge pull request #1483 from jupyterhub/dependabot/github_actions/co…
consideRatio May 25, 2022
0e1813a
Merge pull request #1480 from consideRatio/pr/bump-docker-image-clean…
consideRatio May 25, 2022
6375bae
ci: optimize workflow triggers
consideRatio May 25, 2022
b667eb1
Merge pull request #1487 from consideRatio/pr/avoid-2x-runs
consideRatio May 25, 2022
ef0d01b
Merge pull request #1478 from consideRatio/pr/add-watcher-workflow
consideRatio May 25, 2022
fc97c86
ci: fix triggers by including wildcards
consideRatio May 25, 2022
3b64fac
Merge pull request #1489 from consideRatio/pr/fix-gha-triggers-with-w…
consideRatio May 25, 2022
cb1281b
build(deps): bump docker/setup-qemu-action from 1.2.0 to 2
dependabot[bot] May 25, 2022
92e79fb
Apply suggestions from code review
consideRatio May 25, 2022
2185741
Merge pull request #1488 from jupyterhub/dependabot/github_actions/do…
consideRatio May 25, 2022
09b6604
docs: tweak notes on updating frozen image requirements.txt
consideRatio May 25, 2022
c93c7dc
Update helm chart's binderhub image's frozen requirements.txt
consideRatio May 25, 2022
a25737f
Merge pull request #1490 from consideRatio/pr/update-frozen-image-req…
consideRatio May 25, 2022
5c5524c
ci: minimize risk of caching node/pip dependencies
consideRatio May 25, 2022
0fe0fb9
Merge pull request #1491 from consideRatio/pr/ci-minimize-cache-issues
consideRatio May 25, 2022
9a7ec41
Transition from Python 3.8 to 3.9 in CI and helm chart image
consideRatio May 25, 2022
d787028
Transition from Node 14 to 16 in CI and helm chart image
consideRatio May 25, 2022
64a6ec4
Transition from buster to bullseye in helm chart image
consideRatio May 25, 2022
d5bc960
breaking: start require k8s 1.20+ and test against k8s 1.20 and latest
consideRatio May 25, 2022
46f686c
ci: test at least once with python 3.10
consideRatio May 25, 2022
0990726
Merge pull request #1492 from consideRatio/pr/bump-to-py39-and-node16
consideRatio May 26, 2022
47d7917
Merge pull request #1493 from consideRatio/pr/req-k8s-1.20-and-test-a…
consideRatio May 28, 2022
20697c6
maint: remove ingress conditional no longer needed
consideRatio May 30, 2022
b287517
Merge pull request #1497 from consideRatio/pr/update-ingress-to-no-lo…
consideRatio May 30, 2022
b971822
build(deps): bump peter-evans/create-pull-request from 4.0.3 to 4.0.4
dependabot[bot] Jun 6, 2022
38d7fac
Merge pull request #1498 from jupyterhub/dependabot/github_actions/pe…
consideRatio Jun 6, 2022
efccb2e
docker-image-cleaner 1.0.0-beta.2
manics Jun 11, 2022
248f390
Update env var names for docker-image-cleaner
manics Jun 11, 2022
3755121
Merge pull request #1500 from manics/docker-image-cleaner-1.0.0-beta.2
consideRatio Jun 11, 2022
5a1c062
build(deps): bump actions/setup-python from 3 to 4
dependabot[bot] Jun 13, 2022
a443897
Merge pull request #1501 from jupyterhub/dependabot/github_actions/ac…
consideRatio Jun 13, 2022
2a48fe2
[pre-commit.ci] pre-commit autoupdate
pre-commit-ci[bot] Jun 13, 2022
1f189c2
Merge pull request #1502 from jupyterhub/pre-commit-ci-update-config
consideRatio Jun 13, 2022
c3f020e
build(deps): bump jupyterhub/action-k3s-helm from 2 to 3
dependabot[bot] Jun 13, 2022
b351bd0
Merge pull request #1503 from jupyterhub/dependabot/github_actions/ju…
consideRatio Jun 13, 2022
83f2376
Update certmanager to the latest release
FasihZafar Jun 17, 2022
6994d6d
Merge pull request #1504 from FasihZafar/master
minrk Jun 17, 2022
9506bc8
[pre-commit.ci] pre-commit autoupdate
pre-commit-ci[bot] Jun 20, 2022
ff577e7
Merge pull request #1505 from jupyterhub/pre-commit-ci-update-config
consideRatio Jun 21, 2022
2eb8b07
Bump z2jh version to 1.2.0
yuvipanda Jun 24, 2022
2d15492
Merge pull request #1507 from yuvipanda/bump-z2jh
consideRatio Jun 24, 2022
72c824f
[pre-commit.ci] pre-commit autoupdate
pre-commit-ci[bot] Jul 4, 2022
b3ad65e
Merge pull request #1509 from jupyterhub/pre-commit-ci-update-config
consideRatio Jul 5, 2022
b1361cd
[pre-commit.ci] pre-commit autoupdate
pre-commit-ci[bot] Jul 11, 2022
f6e126e
Merge pull request #1510 from jupyterhub/pre-commit-ci-update-config
consideRatio Jul 12, 2022
7861640
[pre-commit.ci] pre-commit autoupdate
pre-commit-ci[bot] Jul 25, 2022
0fa35a0
Merge pull request #1514 from jupyterhub/pre-commit-ci-update-config
consideRatio Jul 26, 2022
c809aca
Check for errors when submitting builds
manics Jul 30, 2022
a5d29b6
Add back todo about error propagation
manics Aug 1, 2022
72e1852
Remove leftover format spec in error log
manics Aug 1, 2022
a96f8c4
[pre-commit.ci] pre-commit autoupdate
pre-commit-ci[bot] Aug 1, 2022
7fa1d77
Merge pull request #1519 from jupyterhub/pre-commit-ci-update-config
consideRatio Aug 2, 2022
63cfe00
[pre-commit.ci] pre-commit autoupdate
pre-commit-ci[bot] Aug 8, 2022
b78cac3
Merge pull request #1522 from jupyterhub/pre-commit-ci-update-config
consideRatio Aug 9, 2022
9a4ad32
add boto3 requirement
chicocvenancio Aug 10, 2019
dfcb921
add AWSElasticContainerRegistry class
chicocvenancio Aug 27, 2019
a2a670a
rbac.yaml: allow manipulation of secrets
chicocvenancio Aug 27, 2019
25faed2
Revert RBAC modification and remove handling in AWSElasticContainerRe…
ivan-gomes Jan 21, 2020
60c8ed4
Add password and url fetching for ECR
ivan-gomes Jan 21, 2020
6e6a61c
Add AWS ECR documentation
ivan-gomes Jan 21, 2020
b9877a7
Fix wording in AWS ECR documentation
ivan-gomes Jan 21, 2020
a5f21e8
Add ECR host to `image_prefix` in documentation
ivan-gomes Jan 21, 2020
54c1b64
Re-add binder-push-secret patching. Add check for correct auth token.
ivan-gomes Jan 21, 2020
6266cdd
Remove duplicate GetAuthorizationToken in AWS ECR doc
ivan-gomes Jan 30, 2020
dc676c4
Lazily initialize kube_client in AWSElasticContainerRegistry to preve…
ivan-gomes Feb 9, 2020
5a4894a
Rename `registry_class` to `docker_registry_class` for clarity
ivan-gomes May 13, 2020
eeb7661
Move boto3 and kubernetes calls to own threadpool
ivan-gomes Jun 6, 2020
ad97b5a
general word-smithing for clarity
TomasBeuzen Sep 18, 2020
e7624d9
remove stray comma that AWS doesn't like in the policy
TomasBeuzen Sep 18, 2020
378f539
one more small clarification
TomasBeuzen Sep 18, 2020
762443e
Fix rebase mishap
thomas-bc Aug 11, 2022
40ddeeb
update registry_class documentation for ECR
thomas-bc Aug 11, 2022
42a28bf
moving optional boto3 import inside class
thomas-bc Aug 11, 2022
7cf26bf
_patch_docker_config_secret docs and robustness
thomas-bc Aug 12, 2022
d9a983f
make RBAC increase conditional
thomas-bc Aug 12, 2022
4ce6dc1
Merge pull request #1517 from manics/build-submit-check-errors
consideRatio Aug 14, 2022
d04e88e
Replace `Build` class with new traitlets classes
manics Jul 28, 2022
6e65ec4
`Build.cleanup_builds` is now a standalone traitlets-based class
manics Jul 28, 2022
5c68741
Use traitlets BuildExecutor in app
manics Jul 30, 2022
0726b2e
Pass event loop instead of using current()
manics Jul 30, 2022
2a10ed1
CI: don't rely on current ioloop
manics Aug 1, 2022
57a1d8d
ci: test.yml add time limit for jobs
manics Aug 1, 2022
9e20437
Mock Build tests: need to use correct types and set loop
manics Aug 1, 2022
78fb0aa
KubernetesBuildExecutor: ensure traitlets have defaults
manics Aug 2, 2022
bbfb96b
BuildExecutor: appendix git_credentials push_secret q types
manics Aug 8, 2022
99a8ac8
Remove MagicMock from test_build Build params
manics Aug 8, 2022
8b0dafa
Don't pass ioloop around app, only pass to BuildExecutor
manics Aug 8, 2022
eeee549
conftest: io_loop fixture is async
manics Aug 8, 2022
aea5b3d
Setup main_loop inside BuildExecutor
manics Aug 8, 2022
60429f7
Setup main_loop inside BuildExecutor.__init__
manics Aug 8, 2022
e666855
git_credentials must be a string, don't cast
manics Aug 12, 2022
eea8e6e
BuildExecutor.appendix set by traitlets, not passed from BinderHub.ap…
manics Aug 12, 2022
dd2d26c
builder.py deprecation: xref Build class
manics Aug 14, 2022
b49edf6
BuildExecutor.stop: docstring clasrification
manics Aug 14, 2022
c4af713
Merge pull request #1518 from manics/build-traitlets
minrk Aug 15, 2022
482cdb9
Merge branch 'jupyterhub:master' into aws-ecr-support
thomas-bc Aug 16, 2022
591be68
rename RBAC increase to rbac.patchSecrets
thomas-bc Aug 16, 2022
c2b3f6e
Merge branch 'aws-ecr-support' of https://github.com/thomas-bc/binder…
thomas-bc Aug 16, 2022
56f9e81
Merge branch 'aws-ecr-support' of https://github.com/ivan-gomes/binde…
thomas-bc Aug 16, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 0 additions & 37 deletions .circleci/config.yml

This file was deleted.

13 changes: 13 additions & 0 deletions .eslintrc.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
module.exports = {
"env": {
"browser": true,
"jquery": true,
"es6": true
},
"extends": "eslint:recommended",
"parserOptions": {
"sourceType": "module"
},
"rules": {
}
};
16 changes: 16 additions & 0 deletions .flake8
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
# flake8 is a Python linting tool run by pre-commit as declared by our
# pre-commit-config.yaml file.
#
# This configuration is compatible with the autoformatter tool black, and
# further relaxed to not bug us with too small details.
#
# flake8 configuration reference:
# https://flake8.pycqa.org/en/latest/user/configuration.html
#
[flake8]
max-line-length = 88
extend-ignore = C, E, W

# Adjustments to linting the binderhub repo
builtins = c, load_subconfig
exclude = versioneer.py,binderhub/_version.py
21 changes: 21 additions & 0 deletions .git-blame-ignore-revs
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
# This file can be used to disregard certain commits when using `git blame`, and
# GitHub will automatically use it for that by file name convention.
#
# Reference 1: https://git-scm.com/docs/git-blame#Documentation/git-blame.txt---ignore-revs-fileltfilegt
# Reference 2: https://docs.github.com/en/repositories/working-with-files/using-files/viewing-a-file#ignore-commits-in-the-blame-view
#

# pre-commit: run requirements-txt-fixer
da40927c5b187e37755901e675eee092e12ae2eb
# pre-commit: run end-of-file-fixer
b815163691eade7daeeb01549d0fc6bdf4a33186
# pre-commit: run prettier
9fefdc42ec4d1701117f8f2880a80695eeaad5c9
# pre-commit: run update-values-based-on-bindarspawner-mixin
d32e9efa34cf0ca8880939e82ff01d3edc35705b
# pre-commit: run isort
f0fe0257506fd667279e97354f0207168aa1368c
# pre-commit: run black
bb047d8bce89655e197a7fdf2bdec2cb9c79940a
# pre-commit: run pyupgrade
24da4e593461640aaa47dc008b1f657b92189085
1 change: 0 additions & 1 deletion .gitattributes
Original file line number Diff line number Diff line change
@@ -1,2 +1 @@
secrets/** filter=git-crypt diff=git-crypt
binderhub/_version.py export-subst
1 change: 0 additions & 1 deletion .github/ISSUE_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,3 @@ If you aren't sure where to go use https://github.com/jupyterhub/binder/issues/n

Thank you for being awesome!
-->

18 changes: 18 additions & 0 deletions .github/dependabot.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
# dependabot.yml reference: https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file
#
# Notes:
# - Status and logs from dependabot are provided at
# https://github.com/jupyterhub/binderhub/network/updates.
# - YAML anchors are not supported here or in GitHub Workflows.
#
version: 2
updates:
# Maintain dependencies in our GitHub Workflows
- package-ecosystem: github-actions
directory: "/" # This should be / rather than .github/workflows
schedule:
interval: weekly
time: "05:00"
timezone: "Etc/UTC"
labels:
- dependencies
75 changes: 75 additions & 0 deletions .github/workflows/diff.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,75 @@
# This workflow provides a diff of the rendered Helm chart's templates with the
# latest released dev version of the chart.
#
name: Helm diff

on:
pull_request:
paths:
- ".github/workflows/diff.yml"
- "helm-chart/binderhub/**"
push:
paths:
- ".github/workflows/diff.yml"
- "helm-chart/binderhub/**"
branches-ignore:
- "dependabot/**"
- "pre-commit-ci-update-config"
- "update-*"
workflow_dispatch:

jobs:
diff-rendered-templates:
runs-on: ubuntu-20.04
steps:
- uses: actions/checkout@v3
with:
fetch-depth: 0

- uses: jupyterhub/action-k3s-helm@v3
with:
k3s-channel: stable
metrics-enabled: false
traefik-enabled: false
docker-enabled: true

- uses: actions/setup-python@v4
with:
python-version: "3.9"

- name: Install helm diff plugin, update local chart dependencies
run: |
helm plugin install https://github.com/databus23/helm-diff
helm dependency update ./helm-chart/binderhub

- name: "Install latest released dev chart"
run: |
UPGRADE_FROM_VERSION=$(curl -sS https://jupyterhub.github.io/helm-chart/info.json | jq -er '.binderhub.dev')

# NOTE: We change the directory so binderhub the chart name won't be
# misunderstood as the local folder name.
# validation is disabled, because the config is for a different version!
cd testing

old_config="../testing/k8s-binder-k8s-hub/binderhub-chart-config-old.yaml"
if [ -f "$old_config" ]; then
echo "using old config"
else
old_config="../testing/k8s-binder-k8s-hub/binderhub-chart-config.yaml"
fi

helm install binderhub-test binderhub \
--values "$old_config" \
--repo https://jupyterhub.github.io/helm-chart/ \
--disable-openapi-validation \
--version=$UPGRADE_FROM_VERSION

- name: "Helm diff latest released dev chart with local chart"
run: |
echo "NOTE: For the helm diff, we have not updated the Chart.yaml"
echo " version or image tags using chartpress."
echo

helm diff upgrade binderhub-test helm-chart/binderhub \
--values testing/k8s-binder-k8s-hub/binderhub-chart-config.yaml \
--context=3
34 changes: 34 additions & 0 deletions .github/workflows/eslint.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
# Lints the binderhub/static/js folders content with eslint, influenced by
# ".eslintrc.js", by running "npm run lint" where "lint" is a command defined in
# package.json.
#
name: eslint

on:
pull_request:
paths:
- ".github/workflows/eslint.yml"
- ".eslintrc.js"
- "package.json"
- "binderhub/static/js/**"
push:
paths:
- ".github/workflows/eslint.yml"
- ".eslintrc.js"
- "package.json"
- "binderhub/static/js/**"
branches-ignore:
- "dependabot/**"
- "pre-commit-ci-update-config"
- "update-*"
workflow_dispatch:

jobs:
build:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3

- run: npm install

- run: npm run lint
122 changes: 122 additions & 0 deletions .github/workflows/publish.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,122 @@
name: Publish helm chart and docker images

on:
pull_request:
paths-ignore:
- "**.md"
- "**.rst"
- "doc/**"
- "examples/**"
- ".github/workflows/**"
- "!.github/workflows/publish.yml"
push:
paths-ignore:
- "**.md"
- "**.rst"
- "doc/**"
- "examples/**"
- ".github/workflows/**"
- "!.github/workflows/publish.yml"
branches-ignore:
- "dependabot/**"
- "pre-commit-ci-update-config"
- "update-*"
workflow_dispatch:

jobs:
# Builds and pushes docker images to DockerHub, packages the Helm chart and
# pushes it to jupyterhub/helm-chart@gh-pages where index.yaml represents the
# JupyterHub organization Helm chart repository.
#
# ref: https://github.com/jupyterhub/helm-chart
# ref: https://hub.docker.com/orgs/jupyterhub
#
Publish:
runs-on: ubuntu-latest
if: startsWith(github.ref, 'refs/tags/') || (github.ref == 'refs/heads/main') || (github.ref == 'refs/heads/master')
steps:
- uses: actions/checkout@v3
with:
# chartpress requires the full history
fetch-depth: 0
- uses: actions/setup-python@v4
with:
python-version: "3.9"

- name: Set up QEMU (for docker buildx)
uses: docker/setup-qemu-action@v2

- name: Set up Docker Buildx (for chartpress multi-arch builds)
uses: docker/setup-buildx-action@dc7b9719a96d48369863986a06765841d7ea23f6 # dependabot updates to latest release

- name: Install chart publishing dependencies (chartpress, helm)
run: |
. ./ci/common
setup_helm v3.5.4
pip install --no-cache-dir chartpress>=1.2 pyyaml

- name: Setup push rights to jupyterhub/helm-chart
# This was setup by...
# 1. Generating a private/public key pair:
# ssh-keygen -t ed25519 -C "jupyterhub/binderhub" -f /tmp/id_ed25519
# 2. Registering the private key (/tmp/id_ed25519) as a secret for this
# repo:
# https://github.com/jupyterhub/binderhub/settings/secrets/actions
# 3. Registering the public key (/tmp/id_ed25519.pub) as a deploy key
# with push rights for the jupyterhub/helm chart repo:
# https://github.com/jupyterhub/helm-chart/settings/keys
#
run: |
mkdir -p ~/.ssh
ssh-keyscan github.com >> ~/.ssh/known_hosts
echo "${{ secrets.JUPYTERHUB_HELM_CHART_DEPLOY_KEY }}" > ~/.ssh/id_ed25519
chmod 600 ~/.ssh/id_ed25519

- name: Setup push rights to Docker Hub
# This was setup by...
# 1. Creating a Docker Hub service account "jupyterhubbot"
# 2. Making the account part of the "bots" team, and granting that team
# permissions to push to the relevant images:
# https://hub.docker.com/orgs/jupyterhub/teams/bots/permissions
# 3. Registering the username and password as a secret for this repo:
# https://github.com/jupyterhub/binderhub/settings/secrets/actions
#
run: |
docker login -u "${{ secrets.DOCKER_USERNAME }}" -p "${{ secrets.DOCKER_PASSWORD }}"

- name: Configure a git user
# Having a user.email and user.name configured with git is required to
# make commits, which is something chartpress does when publishing.
# While Travis CI had a dummy user by default, GitHub Actions doesn't
# and require this explicitly setup.
run: |
git config --global user.email "[email protected]"
git config --global user.name "GitHub Actions user"

- name: Publish images and chart with chartpress
env:
GITHUB_REPOSITORY: "${{ github.repository }}"
run: |
./tools/generate-json-schema.py
./ci/publish

PyPI-testbuild:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
with:
# Versioneer requires past tags
fetch-depth: 0
- uses: actions/setup-python@v4
with:
python-version: "3.9"
- name: Install pypa/build
run: python -mpip install build
- name: Build a sdist, and a binary wheel from the sdist
run: python -mbuild .
# ref: https://github.com/actions/upload-artifact#readme
- uses: actions/upload-artifact@v3
with:
name: pypi-dist
path: "dist/*"
if-no-files-found: error
Loading