Rebase to current and requested modifications #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
even if spawn finishes produces more consistent output, fewer branches in the code
- streaming callback is scheduled asynchronously, so we aren't guaranteed that it's been called when request finishes - resolve on failure as well, not just success
it won't be awaited properly schedule with `ensure_future` instead
Emit launch events
The JHub API returns a URL with the base_url of hub.
Jupyter packaging, fix sdist, PEP518 build
allows api-only deployments, where only `/hub/api` is routed to the Hub, instead of `/hub/` this duplicate endpoint of `/hub/health` was added in JupyterHub 1.4
use hub/api/health endpoint
…k8s-1.22 Test latest (1.22) and oldest supported and testable (1.18) k8s version
…-in-to-scheduled-codeql-runs ci: stop running scheduled CodeQL jobs that never fail
…ingress helm-chart: bump Ingress k8s apiVersion
We should allow our template to generate properly without forcing users to specify ingress.hosts as it is a viable configuration that has been requested as in z2jh already.
…image-cleaner Rely on docker-image-cleaner in external repo
Check for low-level errors when submitting builds
`BuildExecutor` is the abstract class with common prperties and methods `KubernetesBuildExecutor` is the replacement for the current `Build` class `Build` is kept but deprecated. `LocalRepo2dockerBuild` has never been released and is marked as under development, so breaking changes are fine.
Co-authored-by: Erik Sundell <[email protected]>
Use Traitlets for passing parameters to `Build` classes
…rhub into aws-ecr-support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviving jupyterhub#1055.
Here are the requested changes after review (see here). I also rebased the branch to incorporate the changes since the PR was open.