remove stackdriver e2e tests #50993
Merged
remove stackdriver e2e tests #50993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zirain
requested review from
a team,
costinm,
linsun,
howardjohn,
stevenctl,
ericvn and
hzxuzhonghu
as code owners
istio-policy-bot
added
the
release-notes-none
istio-testing
added
the
size/XXL
howardjohn
approved these changes
May 13, 2024
There was a problem hiding this comment.
LGTM provided @kyessenov or @lei-tang approve.
Do we need to do something with the remaining opencensus code? What happens if a user tries to use it, does envoy fail to startup?
|
@lei-tang please make sure the test continues running on ASM. |
|
@howardjohn The code in Istio/proxy can also be moved private, but unfortunately it's coupled with other Istio filters so it requires careful separation. |
I'm happy to see that happen. |
zirain
force-pushed
the
disable-stackdriver
branch
from
cb29024
to
7dffcb5
Compare
lei-tang
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide a description of this PR:
fixes: #50992
related to envoyproxy/envoy#33912
xref: #50808
cc @lei-tang @kyessenov