Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop stackdriver from test framework #51021

Merged
merged 2 commits into from
May 14, 2024
Merged

Drop stackdriver from test framework #51021

merged 2 commits into from
May 14, 2024

Conversation

howardjohn
Copy link
Member

This was removed from tests so is now dead code

@howardjohn
Drop stackdriver from test framework
d98459f 
This was removed from tests so is now dead code
@howardjohn howardjohn requested a review from a team as a code owner May 13, 2024 23:32
@howardjohn howardjohn added the release-notes-none Indicates a PR that does not require release notes. label May 13, 2024
@istio-testing istio-testing added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label May 13, 2024
@istio-testing istio-testing added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 14, 2024
costinm
costinm reviewed May 14, 2024
View reviewed changes
Copy link
Contributor

@costinm costinm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was it unused - or I missed a PR where code was removed ?

I think it's reasonable - OTLP and collector can handle this much better.

@howardjohn
Copy link
Member Author

Rest removed in #50993

@istio-testing istio-testing merged commit f7ba4ac into istio:master May 14, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@costinm costinm costinm left review comments

@kfaseela kfaseela kfaseela approved these changes

@ericvn ericvn ericvn approved these changes

@linsun linsun Awaiting requested review from linsun linsun is a code owner

@stevenctl stevenctl Awaiting requested review from stevenctl stevenctl is a code owner

@hzxuzhonghu hzxuzhonghu Awaiting requested review from hzxuzhonghu hzxuzhonghu is a code owner

Assignees
No one assigned
Labels
release-notes-none Indicates a PR that does not require release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@howardjohn @costinm @kfaseela @ericvn @istio-testing