add fancier success icons

operator/pkg/name/name.go

@@ -86,6 +86,15 @@ const (
  IstioOperatorCustomResourceName ComponentName = "IstioOperatorCustomResource"
 )
 
+var IstioComponentSuccessIcons = map[ComponentName]string{
+ IstioBaseComponentName: "⛵️",
+ PilotComponentName: "🧠",
+ CNIComponentName: "🪢",
+ ZtunnelComponentName: "🔒",
+ IngressComponentName: "🛬",
+ EgressComponentName: "🛫",
+}
+
 // ComponentNamesConfig is used for unmarshaling legacy and addon naming data.
 type ComponentNamesConfig struct {
  DeprecatedComponentNames []string

operator/pkg/util/progress/progress.go

@@ -111,7 +111,8 @@ func createBar() *pb.ProgressBar {
 // on a new line, and create a new bar. For example, this becomes "x succeeded", "waiting for y, z".
 func (p *Log) reportProgress(component string) func() {
  return func() {
- cliName := name.UserFacingComponentName(name.ComponentName(component))
+ cmpName := name.ComponentName(component)
+ cliName := name.UserFacingComponentName(cmpName)
  p.mu.Lock()
  defer p.mu.Unlock()
  cmp := p.components[component]
@@ -120,11 +121,15 @@ func (p *Log) reportProgress(component string) func() {
  finished := cmp.finished
  cmpErr := cmp.err
  cmp.mu.Unlock()
+ successIcon := "✅"
+ if icon, found := name.IstioComponentSuccessIcons[cmpName]; found {
+ successIcon = icon
+ }
  if finished || cmpErr != "" {
  if finished {
- p.SetMessage(fmt.Sprintf(`{{ green "✔" }} %s installed`, cliName), true)
+ p.SetMessage(fmt.Sprintf(`%s %s installed`, successIcon, cliName), true)
  } else {
- p.SetMessage(fmt.Sprintf(`{{ red "✘" }} %s encountered an error: %s`, cliName, cmpErr), true)
+ p.SetMessage(fmt.Sprintf(`❌ %s encountered an error: %s`, cliName, cmpErr), true)
  }
  // Close the bar out, outputting a new line
  delete(p.components, component)
@@ -146,10 +151,10 @@ func (p *Log) SetState(state InstallState) {
  p.bar.SetTemplateString(inProgress + `Pruning removed resources`)
  p.bar.Write()
  case StateComplete:
- p.bar.SetTemplateString(`{{ green "✔" }} Installation complete`)
+ p.bar.SetTemplateString(`{{ green "✅" }} Installation complete`)
  p.bar.Write()
  case StateUninstallComplete:
- p.bar.SetTemplateString(`{{ green "✔" }} Uninstall complete`)
+ p.bar.SetTemplateString(`{{ green "✅" }} Uninstall complete`)
  p.bar.Write()
  }
 }

operator/pkg/util/progress/progress_test.go

@@ -57,20 +57,20 @@ func TestProgressLog(t *testing.T) {
  expect(`- Processing resources for ` + cnbo + `, ` + cnpo + `. Waiting for deployment`)
 
  bar.ReportError("some error")
- expect(`✘ ` + cnbo + ` encountered an error: some error`)
+ expect(`❌ ` + cnbo + ` encountered an error: some error`)
 
  foo.ReportProgress()
  expect(`- Processing resources for ` + cnpo + `.`)
 
  foo.ReportFinished()
- expect(`✔ ` + cnpo + ` installed`)
+ expect(`🧠 ` + cnpo + ` installed`)
 
  p.SetState(StatePruning)
  expect(`- Pruning removed resources`)
 
  p.SetState(StateComplete)
- expect(`✔ Installation complete`)
+ expect(`✅ Installation complete`)
 
  p.SetState(StateUninstallComplete)
- expect(`✔ Uninstall complete`)
+ expect(`✅ Uninstall complete`)
 }

operator/pkg/verifier/verifier.go

@@ -88,8 +88,8 @@ func NewStatusVerifier(kubeClient kube.CLIClient, client client.Client, istioNam
 ) (*StatusVerifier, error) {
  verifier := StatusVerifier{
  logger: clog.NewDefaultLogger(),
- successMarker: "✔",
- failureMarker: "✘",
+ successMarker: "✅",
+ failureMarker: "❌",
  istioNamespace: istioNamespace,
  manifestsPath: manifestsPath,
  filenames: filenames,