add fancier success icons #50744
add fancier success icons #50744
Conversation
istio-testing
added
the
size/S
Signed-off-by: Ian Rudie <[email protected]>
Signed-off-by: Ian Rudie <[email protected]>
ilrudie
force-pushed
the
fancy-status-icons
branch
from
2c17356
to
a3b88d5
Compare
istio-testing
added
size/M
Signed-off-by: Ian Rudie <[email protected]>
operator/pkg/name/name.go
Outdated
| IngressComponentName: "🚪", | ||
| EgressComponentName: "✋", |
There was a problem hiding this comment.
Maybe use similar or same icons for ingress and egress?
There was a problem hiding this comment.
I thought about 🛫 (plane takeoff/leave) for egress and 🛬 (plane land/arrive) for ingress.
There was a problem hiding this comment.
@linsun, how do you feel about using the planes?
operator/pkg/name/name.go
Outdated
| var IstioComponentSuccessIcons = map[ComponentName]string{ | ||
| IstioBaseComponentName: "⛵️", | ||
| PilotComponentName: "🧠", | ||
| CNIComponentName: "🚦", |
There was a problem hiding this comment.
Do you think it makes sense to use the CNI icon?
There was a problem hiding this comment.
Ideally that'd be great but I don't think there is a unicode character for it. I'll take another look though.
There was a problem hiding this comment.
I tried 🪢 which sort of looks like ethernet cables being woven
Signed-off-by: Ian Rudie <[email protected]>
linsun
added
the
release-notes-none
|
/test release-notes |
|
Most of these characters don't render for me. I think seeing squares wouldn't be the best look. Not everyones terminal/font will have full unicode/emoji support. ⛵️🧠🪢🔒🛬🛫✅❌✅❌ Only 3 of these (the sailboat, the knot and the lock) render for me. |
|
In my case, the first letter of the last message is cut off: |
|
Good it is in master :) thanks @stevenctl and @hanxiaop for reporting it. cc @ilrudie |
|
We can revert it if folks want and I can look at some detection methods so we can have like a fancy set and a safe set to choose from based on detecting what is/isn't supported |
|
An alternative might be to use a simple up/down to indicate success as we were previously but decorate the end of the line with fancy characters. this way if we do get the mystery char box at least what occurred is clear and still readable. when supported: or when not supported: |
Please provide a description of this PR:
added fancier icons for success statuses in istioctl