Add automation documentation tests for migration from sidecar to ambient #1379
Conversation
bmangoen
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1379 +/- ##
=======================================
Coverage 80.55% 80.55%
=======================================
Files 44 44
Lines 2299 2299
=======================================
Hits 1852 1852
Misses 328 328
Partials 119 119 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fjglira
left a comment
fjglira
left a comment
There was a problem hiding this comment.
Looks preatty good in general
|
|
||
| **Environment Validation:** | ||
| [source,console] | ||
| [source,bash,subs="attributes+"] |
There was a problem hiding this comment.
If you want to this command to be executed you will need to add this attribute also: name="istio-migrate-from-sidecar-to-ambient" with the same name of the test that we want to run
There was a problem hiding this comment.
Think on this, every step that you want to be run during the test need to have this attribute
| default istio-system 1 1 1 default Healthy v1.27.0 20m | ||
| ---- | ||
|
|
||
| ifdef::istio-migrate-from-sidecar-to-ambient[] |
There was a problem hiding this comment.
There is no istio control plane installed. So, to achieve this validation we will need in a previous "setup" indef block to deploy the Istio control plane, what you can do is to add maybe a prebuilt function to deploy the Istio CR with default values
| [source,console] | ||
| ---- | ||
| NAME NAMESPACE PROFILE REVISIONS READY IN USE ACTIVE REVISION STATUS VERSION AGE | ||
| default istio-system 1 1 1 default Healthy v1.27.0 20m |
There was a problem hiding this comment.
| default istio-system 1 1 1 default Healthy v1.27.0 20m | |
| default istio-system 1 1 1 default Healthy v{istio_latest_version} 20m |
| # Confirm cluster setup validation passes | ||
| kubectl get ztunnel -n ztunnel | ||
| NAME NAMESPACE PROFILE READY STATUS VERSION AGE | ||
| default ztunnel True Healthy v1.27.0 12m |
There was a problem hiding this comment.
| default ztunnel True Healthy v1.27.0 12m | |
| default ztunnel True Healthy v{istio_latest_version} 12m |
Reorganized doc and added automation test for migration from sidecar to ambient mode Signed-off-by: bmangoen <[email protected]>
Adding prebuilt functions for creating default Istio resource, installing Bookinfo and creating Bookinfo Gateway Signed-off-by: bmangoen <[email protected]>
bmangoen
force-pushed
the
doc/automation-test-migration-sidecar-to-ambient
branch
from
5d5f234 to
b83b8bc
Compare
Signed-off-by: bmangoen <[email protected]>
Signed-off-by: bmangoen <[email protected]>
|
@bmangoen: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
3 participants
What type of PR is this?
What this PR does / why we need it:
Reorganized the migration from sidecar to ambient mode doc part and added automation tests for migration from sidecar to ambient mode
Which issue(s) this PR fixes:
Fixes #1290