Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ComputeTriangleAreas, GetNonManifoldEdges and RemoveNonManifoldEdges in t::geometry::TriangleMesh #6657

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Commits on Apr 30, 2024

  1. Introduce t::geometry::ComputeTriangleAreas method

    Split the logic from ComputeSurfaceArea into a helper static function
    and introduce a new method which computes triangle areas and writes the
    resulting tensor into attributes of the mesh.
    nsaiapova committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    a6ed354 View commit details
    Browse the repository at this point in the history
  2. Implement t::geometry::TriangleMesh::RemoveNonManifoldEdges...

    ... and t::geometry::TriangleMesh::GetNonManifoldEdges methods.
    The methods are defined in geometry::TriangleMesh API.
    
    t::geometry::TriangleMesh::GetNonManifoldEdges mimics the logic of the
    legacy method.
    
    t::geometry::TriangleMesh::RemoveNonManifoldEdges follows the logic of
    the legacy method but there are a few differences:
    * the main difference is that the outer while-loop is removed. I don't
      see how after the first iteration any edge can have more than 2
      adjacent triangles, which makes the further iterations unnecessary.
    * I count triangles with non-negative areas immediately and do not rely
      on the total number of adjacent triangles (which would also include
      triangles marked for removal).
    * To choose a triangle with the minimal area out of the existing
      adjacent triangles I use a heap structure.
    nsaiapova committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    e25faf0 View commit details
    Browse the repository at this point in the history

Commits on May 20, 2024

  1. Configuration menu
    Copy the full SHA
    c33348b View commit details
    Browse the repository at this point in the history