Fix path export command in source installation guide#5062
Open
linzhu-dot wants to merge 1 commit intoisaac-sim:mainfrom
Open
Fix path export command in source installation guide#5062linzhu-dot wants to merge 1 commit intoisaac-sim:mainfrom
linzhu-dot wants to merge 1 commit intoisaac-sim:mainfrom
Conversation
ISAACSIM_PATH is wrong because ${pwd} is empty; only $PWD or $(pwd) or ${PWD} work.
Signed-off-by: linzhu-dot <linzhu@nvidia.com>
Contributor
Greptile SummaryThis PR fixes a shell syntax error in the source installation guide where
Confidence Score: 5/5
Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[User runs source installation guide] --> B["export ISAACSIM_PATH=..."]
B --> C{Shell syntax used?}
C -- "Before fix: \${pwd}" --> D["Variable expansion for 'pwd'\n(undefined variable)"]
D --> E["ISAACSIM_PATH = '/_build/linux-x86_64/release'\n(empty prefix — broken path)"]
C -- "After fix: \$(pwd)" --> F["Command substitution:\nruns the pwd command"]
F --> G["ISAACSIM_PATH = '/home/user/isaaclab/_build/linux-x86_64/release'\n(correct full path)"]
G --> H["export ISAACSIM_PYTHON_EXE=\${ISAACSIM_PATH}/python.sh"]
E --> I["export ISAACSIM_PYTHON_EXE fails — path is wrong"]
Last reviewed commit: "Fix path export comm..." |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ISAACSIM_PATH is wrong because ${pwd} is empty; only$PWD or $ (pwd) or ${PWD} work.
Type of change