Fix exception during io_descriptors creation#5058
Open
prina404 wants to merge 1 commit intoisaac-sim:developfrom
Open
Fix exception during io_descriptors creation#5058prina404 wants to merge 1 commit intoisaac-sim:developfrom
prina404 wants to merge 1 commit intoisaac-sim:developfrom
Conversation
Contributor
Greptile SummaryThis PR fixes a runtime exception in Key points:
Confidence Score: 4/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant Env as ManagerBasedEnv
participant IoDesc as export_articulations_data()
participant ArtData as ArticulationData (wp.array)
participant WP as wp.to_torch()
participant Torch as PyTorch Tensor
Env->>IoDesc: call export_articulations_data(env)
IoDesc->>ArtData: articulation.data.default_joint_pos
ArtData-->>IoDesc: wp.array
IoDesc->>WP: wp.to_torch(wp.array)
WP-->>IoDesc: torch.Tensor
IoDesc->>Torch: [0].detach().cpu().numpy().tolist()
Torch-->>IoDesc: list[float]
Note over IoDesc: Repeated for all 7 data fields
IoDesc-->>Env: dict[str, dict[str, list[float]]]
Last reviewed commit: "Fix exception raised..." |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added
wp.to_torchwrappers needed for io_descriptors creation in ManagerBasedEnv.This PR partially fixes #5057
Type of change
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there