Skip to content

Adds Isaac-Stack-Cube-Franka-IK-Rel-v0 task variants with varying stack orders#4875

Merged
kellyguo11 merged 2 commits intoisaac-sim:mainfrom
nv-caelan:caelan/stack_success_order
Mar 8, 2026
Merged

Adds Isaac-Stack-Cube-Franka-IK-Rel-v0 task variants with varying stack orders#4875
kellyguo11 merged 2 commits intoisaac-sim:mainfrom
nv-caelan:caelan/stack_success_order

Conversation

@nv-caelan
Copy link
Contributor

@nv-caelan nv-caelan commented Mar 7, 2026

Description

This PR adds 4 new Isaac-Stack-Cube-Franka-IK-Rel-v0 task variants corresponding to stacking [Red, Green], [Red, Green, Blue], [Blue, Green], and [Blue, Green, Red]. The objective is to create a test bed for different success conditions in the same scene.

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read and understood the contribution guidelines
  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

@nv-caelan nv-caelan requested a review from Mayankm96 as a code owner March 7, 2026 19:26
@github-actions github-actions bot added the isaac-lab Related to Isaac Lab team label Mar 7, 2026
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Mar 7, 2026

Greptile Summary

This PR adds 4 new Isaac Lab manipulation task variants for stacking cubes in different color orders (Red-Green, Red-Green-Blue, Blue-Green, Blue-Green-Red), creating a testbed for evaluating different success conditions in the same scene. The cubes_stacked termination function is cleanly refactored to make the third cube optional (cube_3_cfg: SceneEntityCfg | None), enabling 2-cube stacking checks while remaining fully backward-compatible with the existing 3-cube default. The cube-to-color mappings (cube_1=Blue, cube_2=Red, cube_3=Green) are correctly applied across all new configs, and the new environment registrations are properly configured.

Key changes:

  • terminations.py: cube_3_cfg parameter made optional with an if cube_3_cfg is not None guard; type annotations added to atol, rtol, and return type
  • stack_ik_rel_env_cfg.py: 4 new @configclass environments each override terminations.success with the correct cube order
  • __init__.py: 4 new gym.register entries added with correct entry points
  • All changes are logically correct and the refactoring is backward-compatible

Confidence Score: 5/5

  • This PR is safe to merge with no identified issues. All new task variants are logically correct with proper cube-color mappings and the termination logic refactoring is backward-compatible.
  • The core implementation is verified correct: (1) the cubes_stacked refactor properly makes the third cube optional with correct conditional logic, (2) all 4 new environment configs correctly map cube entities to their intended stacking order, (3) gym registrations are properly configured with correct entry points, and (4) existing functionality remains intact. No logic errors, syntax issues, or safety concerns identified.
  • No files require special attention

Last reviewed commit: a323142

@kellyguo11 kellyguo11 changed the title Add Isaac-Stack-Cube-Franka-IK-Rel-v0 task variants with varying stack orders Adds Isaac-Stack-Cube-Franka-IK-Rel-v0 task variants with varying stack orders Mar 7, 2026
Copy link
Contributor

@njawale42 njawale42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@kellyguo11 kellyguo11 merged commit 87608f0 into isaac-sim:main Mar 8, 2026
6 of 10 checks passed
@nv-caelan nv-caelan deleted the caelan/stack_success_order branch March 8, 2026 19:10
kellyguo11 added a commit that referenced this pull request Mar 12, 2026
)

# Description

* [Adds Isaac-Stack-Cube-Franka-IK-Rel-v0 task variants with varying
stack orders](#4875)
* [Updates minor RSL-RL configclass
docstring](#4909)

## Type of change

<!-- As you go through the list, delete the ones that are not
applicable. -->

- Bug fix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- Breaking change (existing functionality will not work without user
modification)
- Documentation update


## Checklist

- [x] I have read and understood the [contribution
guidelines](https://isaac-sim.github.io/IsaacLab/main/source/refs/contributing.html)
- [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
`./isaaclab.sh --format`
- [x] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] I have updated the changelog and the corresponding version in the
extension's `config/extension.toml` file
- [ ] I have added my name to the `CONTRIBUTORS.md` or my name already
exists there

<!--
As you go through the checklist above, you can mark something as done by
putting an x character in it

For example,
- [x] I have done this task
- [ ] I have not done this task
-->

---------

Signed-off-by: Kelly Guo <kellyg@nvidia.com>
Signed-off-by: Kelly Guo <kellyguo123@hotmail.com>
Co-authored-by: nv-caelan <cgarrett@nvidia.com>
Co-authored-by: Clemens Schwarke <96480707+ClemensSchwarke@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

isaac-lab Related to Isaac Lab team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants