Skip to content

Sets enable_stabilization to false by default. #2628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Sets enable_stabilization to false by default. #2628

wants to merge 2 commits into from
+8 −2

Conversation

AntoineRichard
Copy link
Contributor

@AntoineRichard AntoineRichard commented Jun 5, 2025 •
edited
Loading

Description

Changes the default setting for the enable stabilization flag from True to False.

Fixes #2319

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Screenshots

Before After
net_contact_forces_1kz net_contact_forces_after
force_matrices_1khz force_matrices_after

Checklist

  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

@AntoineRichard AntoineRichard marked this pull request as ready for review June 6, 2025 09:34
@kellyguo11 kellyguo11 changed the title Setting enable_stabilization to false by default. Sets enable_stabilization to false by default. Jun 9, 2025
@kellyguo11
Copy link
Contributor

test_rigid_object.py seems to be failing, could you check if it's passing locally?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mayankm96 Mayankm96 Awaiting requested review from Mayankm96 Mayankm96 is a code owner

@jsmith-bdai jsmith-bdai Awaiting requested review from jsmith-bdai jsmith-bdai is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AntoineRichard @kellyguo11