-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Updates to ray caster ray alignment and more customizable drift sampling #2556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
* Adds a new ray_alignment parameter - either world, yaw, or base * Fixes drift height sampling
NOTE: It might make sense to have |
Also, I likely need to fix the ray caster tests, just want to get some feedback on the feature changes before doing so |
Yes, please, let's try not to break the interface. |
👍 I've added backwards compatibility now! Maybe we can drop support in 2 releases? |
Sounds good, thanks |
We might need to update some of the environment configs, the anymal C rough locomotion environment is failing unit tests. |
This PR pushes some changes from our internal RAI fork of Isaac Lab.
The 2 main changes are:
Adds a new
ray_alignment
parameter to replace the previousyaw_only
arg.Now the ray alignment can be aligned to
world
,yaw
, or `base.Improves drift height sampling
At the moment, the
RayCasterCfg
hosts a parameter calleddrift_range
. It allows to randomize the position of the sensor in world frame, which comes with a couple of downsides:This PR adds a new parameter ray_cast_drift_range. It gives more freedom in choosing the drift ranges as x, y and z components can be treated separately. It also applies the drift after projecting and rotating the ray cast points, i.e. the drift is now invariant under the yaw angle and the drift in z is can be visualized
I've added Fabian Jenelten and Jeonghwan Kim to this PR as they worked on these changes within RAI - I'm simply helping to push them up 😄
Type of change
Checklist
pre-commit
checks with./isaaclab.sh --format
config/extension.toml
fileCONTRIBUTORS.md
or my name already exists there