Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: SB3 optimizations (3x faster) #2022

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

araffin
Copy link

@araffin araffin commented Mar 5, 2025

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.
List any dependencies that are required for this change.

Implement part of #1769 (optimization)

This is a breaking change because the fast variant is now enabled by default.

I also improve sb3 training script, fixed loading of normalization and fixed the humanoid hyperparameters to be similar to rsl-rl, so we can compare apples to apples in terms of training speed.

I will probably open another PR for the rest of the proposals.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

With respect to testing, how do you run a single test?
and is there anything I should add?

Checklist

  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

@araffin
Copy link
Author

araffin commented Mar 7, 2025

@Mayankm96 failure on the CI seems to be due to a timeout, probably unrelated to this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant