Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moves creating Trimesh from USD prim to an util function #2007

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

Mayankm96
Copy link
Contributor

@Mayankm96 Mayankm96 commented Mar 4, 2025

Description

Previously, the TerrainImporter and RayCaster were storing a copy of the meshes added to the simulation. While we now remove the meshes from the terrain importer, we still want to keep the option to read meshes from the USD or at least provide a utility for it. This might be helpful in places where users want to generate commands on rough terrains.

This MR moves the reading USD mesh prims from the RayCaster into its own function.It simplifies the ray caster code and also does the job as a util function.

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist

  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

@Mayankm96 Mayankm96 changed the base branch from main to fix/remove-warp-meshes-terrain March 4, 2025 09:42
Base automatically changed from fix/remove-warp-meshes-terrain to main March 9, 2025 05:47
@Mayankm96 Mayankm96 added the enhancement New feature or request label Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant