Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes JointAction offsets not updated on reset #1965

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

renezurbruegg
Copy link
Collaborator

@renezurbruegg renezurbruegg commented Feb 27, 2025

Description

Currently, when a user updates the default joint offsets in an environment, the corresponding fields in the JointAction terms are not updated.
This PR updates the joint offsets in the joint actions when the environment is reset.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Screenshots

Checklist

  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

@renezurbruegg
Copy link
Collaborator Author

renezurbruegg commented Feb 27, 2025

I assume this is not a very common use case, but was an issue for me. I change the default joint states on environment resets, leading to wrong actions.

@renezurbruegg renezurbruegg self-assigned this Feb 27, 2025
@renezurbruegg renezurbruegg added the bug Something isn't working label Feb 27, 2025
@kellyguo11 kellyguo11 changed the title Fix JointAction offsets not updated on reset Fixes JointAction offsets not updated on reset Mar 9, 2025
Copy link
Contributor

@kellyguo11 kellyguo11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! Could you also add a quick update to the changelog and extension.toml versioning for the isaaclab extension?

Copy link
Contributor

@kellyguo11 kellyguo11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noticed a couple of unit tests are failing, looks like some shape mismatch issues with the offset.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants