Improve observation manager for observation groups with history_length != None
.
#1958
+226
−56
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes some low-level changes to the
observation_manager
, particularly w/r/t how it handlesObservationGroups
with non-zerohistory_length
. It first changes how the observation group shapes are computed - which fixes a shape bug in theenv.observation_space
for this group downstream.It also changes the handling of flattened obs groups to construct tensors in a way that the history dimension is preserved.
Fixes #1957.
Type of change
Unsure if this is a bugfix or breaking change, since it would change the ordering of elements in observation groups with
history_length != None
. Policies trained with the old ordering would not work - but the proposed ordering seems more in line with the shapes described in the documentation.Checklist
pre-commit
checks with./isaaclab.sh --format
config/extension.toml
fileCONTRIBUTORS.md
or my name already exists there