Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds action clipping options for OperationalSpaceControllerAction #1856

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

ozhanozen
Copy link
Contributor

Description

This PR adds the feature to set clipping thresholds for the OperationalSpaceControllerAction.

Depending on the target_type, the physical interpretation of the clipping differs:

  • For wrench_abs, it is a limit for the applied contact force
  • For pose_rel, it is effectively a limit for the end-effector velocity.
  • For pose_abs, it is an end-effector workspace limit. For the orientation part, which is represented as a quaternion, I have calculated a delta rotation (wrt zero quaternion, i.e., (1,0,0,0)), applied the clipping on this, and finally applied the resulting clipped delta rotation back to the zero quaternion to get the new processed actions.

Moreover, the PR also adds a public member function to modify these clip values during the training, for potential use cases such as clip threshold randomization or curriculum purposes.

Related to #1548 and maybe #1732. Currently, the clipping in OperationalSpaceControllerAction is managed using its class attributes (without dictionaries) but could be later extended to ActionTermCfg.

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

@kellyguo11
Copy link
Contributor

Thanks for this! @oahmednv could you please review as well?

@ozhanozen
Copy link
Contributor Author

I have converted clip and scale parameters –and the respective public functions to modify them during training– to be in the batched form, as such is more useful for domain randomization. Moreover, I fixed some relevant docstring typos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants