-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds action clipping options for OperationalSpaceControllerAction
#1856
Open
ozhanozen
wants to merge
13
commits into
isaac-sim:main
Choose a base branch
from
Swiss-Battery-Technology-Center:feat/osc-action-clipping
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Adds action clipping options for OperationalSpaceControllerAction
#1856
ozhanozen
wants to merge
13
commits into
isaac-sim:main
from
Swiss-Battery-Technology-Center:feat/osc-action-clipping
+179
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for this! @oahmednv could you please review as well? |
…modification functions
I have converted clip and scale parameters –and the respective public functions to modify them during training– to be in the batched form, as such is more useful for domain randomization. Moreover, I fixed some relevant docstring typos. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the feature to set clipping thresholds for the
OperationalSpaceControllerAction
.Depending on the
target_type
, the physical interpretation of the clipping differs:wrench_abs
, it is a limit for the applied contact forcepose_rel
, it is effectively a limit for the end-effector velocity.pose_abs
, it is an end-effector workspace limit. For the orientation part, which is represented as a quaternion, I have calculated a delta rotation (wrt zero quaternion, i.e.,(1,0,0,0)
), applied the clipping on this, and finally applied the resulting clipped delta rotation back to the zero quaternion to get the new processed actions.Moreover, the PR also adds a public member function to modify these clip values during the training, for potential use cases such as clip threshold randomization or curriculum purposes.
Related to #1548 and maybe #1732. Currently, the clipping in
OperationalSpaceControllerAction
is managed using its class attributes (without dictionaries) but could be later extended toActionTermCfg.
Type of change
Checklist
pre-commit
checks with./isaaclab.sh --format
config/extension.toml
fileCONTRIBUTORS.md
or my name already exists there