feat(auth, oauth): add native oauth support / no external packages needed #7019

Aetherall · 2023-04-03T15:07:09Z

Description

Right now, documentation recommendation for oauth flows is to use the react-native-app-auth package.
What this package do is pretty close to the default behaviour of the firebase native sdk.

With the support of my company and of my teammates from kraaft.co, I had some time allocated to check whether I can bridge the native sdk with react native within react-native-firebase :)

The goals of such integration would be:

reduce the number of dependencies of the project
- no need for react-native-app-auth if firebase does the same
avoid manual fetching of the configuration needed for each provider into react-native-app-auth
- they are dynamic in our use case

Related issues

#349
#3926

Release Summary

Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
- Yes
My change supports the following platforms;
- Android
- iOS -> If anyone knows his swift I'm down for some help :)
My change includes tests;
- e2e tests added or updated in packages/\*\*/e2e -> Would like to have some insights with detox and testing the popup
- jest tests added or updated in packages/\*\*/__tests__
I have updated TypeScript types that are affected by my change.
This is a breaking change;
- Yes
- No

Test Plan

we are deploying this on our staging, and will QA this soon

Think react-native-firebase is great? Please consider supporting the project with any of the below:

👉 Star this repo on GitHub ⭐️
👉 Follow React Native Firebase and Invertase on Twitter

🔥

vercel · 2023-04-03T15:07:15Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
react-native-firebase	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 29, 2023 9:34pm

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
react-native-firebase-next	⬜️ Ignored (Inspect)			Jun 29, 2023 9:34pm

CLAassistant · 2023-04-03T15:07:17Z

All committers have signed the CLA.

Aetherall · 2023-04-07T09:16:35Z

working for android, ios coming soon

Aetherall · 2023-04-11T13:31:16Z

@cedricboidin has added ios

Aetherall · 2023-05-03T08:37:20Z

Rebased on main.

I would appreciate some feedback on this PR :)
Nice day everyone

github-actions · 2023-05-31T09:35:56Z

Hello 👋, this PR has been opened for more than 2 months with no activity on it.

If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing!

You have 15 days until this gets closed automatically

mikehardy · 2023-06-05T17:40:10Z

Sincere apologies for the delay! I'm processing the PR queue now and should have time to review this, I sincerely appreciate the effort and the patience

mikehardy

This looks great! Happy to hear it's working for you in production that gives me a lot of confidence as I look to merge this.

I left a couple specific comments that are hopefully easy to handle

I rebased to current main and ran the linters so those hoops have already been jumped through

The only thing I can think of besides the specific comments is to add something in docs/auth - might make sense to great make a page there (slicing in to the prev/next links on two of the related pages to get the circular nav links going) ?

Functionally CI should go green now though 🤞 with fully up to date SDKs etc etc

mikehardy · 2023-06-29T21:24:29Z

packages/auth/lib/index.d.ts

+ signInWithPopup(provider: AuthProvider): Promise<UserCredential>;
+ signInWithRedirect(provider: AuthProvider): Promise<UserCredential>;


Can you document this here, even if briefly? The rnfirebase.io site is built from the typedoc so anything you put here will be seen + used

mikehardy · 2023-06-29T21:26:38Z

...ges/auth/android/src/main/java/io/invertase/firebase/auth/ReactNativeFirebaseAuthModule.java

@@ -1950,6 +2074,7 @@ private WritableMap getJSError(Exception exception) {
 String message = exception.getMessage();
 String invalidEmail = "The email address is badly formatted.";

+ System.out.print(exception);


Dumping an error to System.out is discouraged, if it is already being propagated up, then I think this could be removed?

mikehardy · 2023-06-29T21:52:56Z

Looks like another of the test cases needs a modification similar to those already made:

  1) auth().currentUser
       linkWithPopup()
         should throw an unsupported error:
     AssertionError: expected Function { name: '' } to throw exception with a message matching 'firebase.auth.User.linkWithPopup() is unsupported by the native Firebase SDKs.', but got 'Cannot read properties of undefined (reading 'providerId')'
      at Assertion.fail (node_modules/should/cjs/should.js:275:17)
      at Assertion.value (node_modules/should/cjs/should.js:356:19)
      at Context.<anonymous> (/Users/runner/work/react-native-firebase/react-native-firebase/packages/auth/e2e/user.e2e.js:880:22)

github-actions · 2023-07-27T22:35:51Z

Hello 👋, this PR has been opened for more than 2 months with no activity on it.

If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing!

You have 15 days until this gets closed automatically

mikehardy · 2023-08-18T00:00:25Z

Summer vacation time was busy enough the stale bot got this one, but it's a good looking chunk of work, hoping to get it shepherded through for merge

github-actions · 2023-09-15T00:51:53Z

Hello 👋, this PR has been opened for more than 2 months with no activity on it.

If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing!

You have 15 days until this gets closed automatically

mikehardy · 2024-03-25T17:21:24Z

scanning stale closed queue for unrelated reasons this still looks harvest-able

github-actions · 2024-04-22T17:36:01Z

Hello 👋, this PR has been opened for more than 2 months with no activity on it.

If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing!

You have 15 days until this gets closed automatically

vercel bot deployed to Preview – react-native-firebase April 3, 2023 15:12 View deployment

Aetherall force-pushed the oauth branch from 805575a to 3487b91 Compare April 3, 2023 15:56

vercel bot deployed to Preview – react-native-firebase April 3, 2023 16:02 View deployment

Aetherall force-pushed the oauth branch from 3487b91 to 2f9e29d Compare April 4, 2023 09:40

vercel bot deployed to Preview – react-native-firebase April 4, 2023 09:46 View deployment

Aetherall force-pushed the oauth branch from 2f9e29d to 15707e8 Compare April 4, 2023 12:24

vercel bot deployed to Preview – react-native-firebase April 4, 2023 12:29 View deployment

Aetherall force-pushed the oauth branch from 15707e8 to b8358b7 Compare April 4, 2023 12:46

vercel bot deployed to Preview – react-native-firebase April 4, 2023 12:52 View deployment

Aetherall force-pushed the oauth branch from b8358b7 to f62e718 Compare April 4, 2023 15:08

vercel bot deployed to Preview – react-native-firebase April 4, 2023 15:13 View deployment

Aetherall force-pushed the oauth branch from f62e718 to 5acc802 Compare April 7, 2023 08:26

vercel bot deployed to Preview – react-native-firebase April 7, 2023 08:30 View deployment

cedricboidin force-pushed the oauth branch from 5acc802 to 4a5a861 Compare April 11, 2023 13:24

vercel bot deployed to Preview – react-native-firebase April 11, 2023 13:29 View deployment

Aetherall changed the title ~~WIP feat(oauth): added signIn and link for oauth~~ feat(oauth): added signIn and link for oauth Apr 11, 2023

Aetherall marked this pull request as ready for review April 11, 2023 13:32

Aetherall changed the title ~~feat(oauth): added signIn and link for oauth~~ feat(oauth): OAuth Support Natively RFR ( without external packages ) Apr 18, 2023

vercel bot deployed to Preview – react-native-firebase April 18, 2023 15:24 View deployment

vercel bot deployed to Preview – react-native-firebase April 26, 2023 20:57 View deployment

Aetherall force-pushed the oauth branch from 4d1aec7 to 3a4935d Compare May 3, 2023 08:27

vercel bot deployed to Preview – react-native-firebase May 3, 2023 08:38 View deployment

github-actions bot added the Stale label May 31, 2023

Aetherall and others added 5 commits June 29, 2023 16:20

feat(oauth): added signIn and link for oauth

dd8a3ca

ios: on AuthError, send email in userInfo

c7b3a37

use prompt select_account

4d35fb3

handle email error on android

21d7c18

fix(auth): signInWithRedirect uses provider

1710fde

mikehardy force-pushed the oauth branch from 3a4935d to 1710fde Compare June 29, 2023 21:20

vercel bot deployed to Preview – react-native-firebase June 29, 2023 21:28 View deployment

style(lint): yarn lint:ios:fix && yarn lint:android

20fbbd5

vercel bot deployed to Preview – react-native-firebase June 29, 2023 21:34 View deployment

mikehardy requested changes Jun 29, 2023

View reviewed changes

mikehardy added Workflow: Waiting for User Response Blocked waiting for user response. and removed Workflow: Needs Review Pending feedback or review from a maintainer. labels Jun 29, 2023

github-actions bot added the Stale label Jul 27, 2023

github-actions bot closed this Aug 11, 2023

mikehardy reopened this Aug 18, 2023

github-actions bot removed the Stale label Aug 18, 2023

github-actions bot added the Stale label Sep 15, 2023

github-actions bot closed this Sep 30, 2023

mikehardy reopened this Mar 25, 2024

mikehardy added Workflow: Needs Review Pending feedback or review from a maintainer. and removed Stale labels Mar 25, 2024

github-actions bot added the Stale label Apr 22, 2024

mikehardy added Keep Open avoids the stale bot and removed Stale labels May 2, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(auth, oauth): add native oauth support / no external packages needed #7019

feat(auth, oauth): add native oauth support / no external packages needed #7019

Aetherall commented Apr 3, 2023 •

edited

vercel bot commented Apr 3, 2023 •

edited

CLAassistant commented Apr 3, 2023 •

edited

Aetherall commented Apr 7, 2023 •

edited

Aetherall commented Apr 11, 2023

Aetherall commented May 3, 2023

github-actions bot commented May 31, 2023

mikehardy commented Jun 5, 2023

mikehardy left a comment

mikehardy Jun 29, 2023

mikehardy Jun 29, 2023

mikehardy commented Jun 29, 2023

github-actions bot commented Jul 27, 2023

mikehardy commented Aug 18, 2023

github-actions bot commented Sep 15, 2023

mikehardy commented Mar 25, 2024

github-actions bot commented Apr 22, 2024

		signInWithPopup(provider: AuthProvider): Promise<UserCredential>;
		signInWithRedirect(provider: AuthProvider): Promise<UserCredential>;

feat(auth, oauth): add native oauth support / no external packages needed #7019

Are you sure you want to change the base?

feat(auth, oauth): add native oauth support / no external packages needed #7019

Conversation

Aetherall commented Apr 3, 2023 • edited

Description

Related issues

Release Summary

Checklist

Test Plan

we are deploying this on our staging, and will QA this soon

vercel bot commented Apr 3, 2023 • edited

CLAassistant commented Apr 3, 2023 • edited

Aetherall commented Apr 7, 2023 • edited

Aetherall commented Apr 11, 2023

Aetherall commented May 3, 2023

github-actions bot commented May 31, 2023

mikehardy commented Jun 5, 2023

mikehardy left a comment

Choose a reason for hiding this comment

mikehardy Jun 29, 2023

Choose a reason for hiding this comment

mikehardy Jun 29, 2023

Choose a reason for hiding this comment

mikehardy commented Jun 29, 2023

github-actions bot commented Jul 27, 2023

mikehardy commented Aug 18, 2023

github-actions bot commented Sep 15, 2023

mikehardy commented Mar 25, 2024

github-actions bot commented Apr 22, 2024

Aetherall commented Apr 3, 2023 •

edited

vercel bot commented Apr 3, 2023 •

edited

CLAassistant commented Apr 3, 2023 •

edited

Aetherall commented Apr 7, 2023 •

edited