Skip to content

Commit

Permalink
fix(auth): signInWithRedirect uses provider
Browse files Browse the repository at this point in the history
  • Loading branch information
Aetherall authored and mikehardy committed Jun 29, 2023
1 parent 21d7c18 commit 1710fde
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions packages/auth/lib/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -366,10 +366,8 @@ class FirebaseAuthModule extends FirebaseModule {
.then(userCredential => this._setUserCredential(userCredential));

Check warning on line 366 in packages/auth/lib/index.js

View check run for this annotation

Codecov / codecov/patch

packages/auth/lib/index.js#L366

Added line #L366 was not covered by tests
}

signInWithRedirect() {
return this.native
.signInWithProvider(provider.providerId, provider.customParameters?.login_hint)
.then(userCredential => this._setUserCredential(userCredential));
signInWithRedirect(provider) {
return this.signInWithPopup(provider);

Check warning on line 370 in packages/auth/lib/index.js

View check run for this annotation

Codecov / codecov/patch

packages/auth/lib/index.js#L369-L370

Added lines #L369 - L370 were not covered by tests
}

// firebase issue - https://github.com/invertase/react-native-firebase/pull/655#issuecomment-349904680
Expand Down

0 comments on commit 1710fde

Please sign in to comment.