Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preview: do not mint parent doi if doi is not reserved and doi is opt… #2966

Merged
merged 1 commit into from
Jan 23, 2025
Merged

preview: do not mint parent doi if doi is not reserved and doi is opt… #2966

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 21 additions & 5 deletions invenio_app_rdm/records_ui/views/records.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ def record_detail(
)
except ValidationError:
abort(404)
# inject parent doi format for new drafts so we can show in preview
# inject parent doi format for new drafts so we can show in preview if parent doi is required
if current_app.config["DATACITE_ENABLED"]:
service = current_rdm_records.records_service
datacite_provider = [
Expand All @@ -187,11 +187,27 @@ def record_detail(
if p == "doi" and "datacite" in v
]
if datacite_provider:
datacite_provider = datacite_provider[0]
parent_doi = datacite_provider.client.generate_doi(
record._record.parent
should_mint_parent_doi = True
is_doi_required = (
current_app.config.get("RDM_PARENT_PERSISTENT_IDENTIFIERS", {})
.get("doi", {})
.get("required")
)
record_ui["ui"]["new_draft_parent_doi"] = parent_doi
if not is_doi_required:
# check if the draft has a reserved doi and mint parent doi only in that case
record_doi = record._record.pids.get("doi", {})
is_doi_reserved = record_doi.get(
"provider", ""
) == "datacite" and record_doi.get("identifier")
if not is_doi_reserved:
should_mint_parent_doi = False

if should_mint_parent_doi:
datacite_provider = datacite_provider[0]
parent_doi = datacite_provider.client.generate_doi(
record._record.parent
)
record_ui["ui"]["new_draft_parent_doi"] = parent_doi

# emit a record view stats event
emitter = current_stats.get_event_emitter("record-view")
Expand Down
Loading