Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preview: do not mint parent doi if doi is not reserved and doi is opt… #2966

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

zzacharo
Copy link
Member

When doi is optional, then the parent doi should be minted when previewing a record only when a local managed record doi is reserved.

Before

Screenshot 2025-01-22 at 11 41 25

After

Screenshot 2025-01-22 at 11 39 35

Copy link
Contributor

@jrcastro2 jrcastro2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Is a nice improvement, left a question to confirm I understand correctly the issue.

invenio_app_rdm/records_ui/views/records.py Show resolved Hide resolved
@jrcastro2 jrcastro2 merged commit 348de12 into inveniosoftware:master Jan 23, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants