Skip to content

[SYCL] Pass SPIR-V extensions explicitly to jit compiler #17359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 11, 2025

Conversation

MrSidims
Copy link
Contributor

@MrSidims MrSidims commented Mar 7, 2025

Resolves #16597

This patch also adds few other missing options

@MrSidims MrSidims marked this pull request as ready for review March 7, 2025 16:16
@MrSidims MrSidims requested a review from a team as a code owner March 7, 2025 16:16
@sommerlukas sommerlukas requested a review from jopperm March 7, 2025 16:33
Signed-off-by: Sidorov, Dmitry <[email protected]>
Signed-off-by: Sidorov, Dmitry <[email protected]>
@MrSidims MrSidims requested a review from a team as a code owner March 10, 2025 11:05
@MrSidims MrSidims requested a review from sommerlukas March 10, 2025 11:06
Signed-off-by: Sidorov, Dmitry <[email protected]>
Copy link
Contributor

@sommerlukas sommerlukas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes!

Signed-off-by: Sidorov, Dmitry <[email protected]>
@sommerlukas sommerlukas changed the title [NFCI][SYCL] Pass SPIR-V extensions explicitly to jit compiler [SYCL] Pass SPIR-V extensions explicitly to jit compiler Mar 11, 2025
@sommerlukas
Copy link
Contributor

This patch also adds few other missing options

Based on this, I've removed the NFC tag from this PR.

@sommerlukas sommerlukas merged commit baa517d into intel:sycl Mar 11, 2025
23 checks passed
adamfidel pushed a commit to reble/llvm that referenced this pull request Mar 11, 2025
Resolves intel#16597

This patch also adds few other missing options

---------

Signed-off-by: Sidorov, Dmitry <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kernel_compiler_sycl_jit failed on Windows with SPV_EXT_optnone support.
4 participants