[WIP][NFC] Hoist non-dot-encoding-sensitive inferOpEncoding to base class #3614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LiyangLingIntel
changed the title
LiyangLingIntel
changed the title
LiyangLingIntel
force-pushed
the
liyang/reduce_inferlayoutinterfance_duplication
branch
from
7665a2b to
0e93907
Compare
|
This PR is pending on the upstream PR feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is to cancle some pure virtual function and move those not backend sensitive inferOpLayout functions to base class as default behavior of the virtual functions. So that these function implementation can be shared by derived classes.
The common files changes will be upstreamed.