Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: aarch64: Run in CI #822

Closed
wants to merge 10 commits into from
Closed

Conversation

pfilipko1
Copy link
Contributor

@Jongy
Copy link
Contributor

Jongy commented Jul 6, 2023

@pfilipko1 based on this

Run ./scripts/build_aarch64_container.sh
unknown flag: --platform
See 'docker --help'.

Usage:  docker [OPTIONS] COMMAND

A self-sufficient runtime for containers

I think we lack docker buildx on the runner, I suppose there's a publicly-available action to install it.

@Jongy
Copy link
Contributor

Jongy commented Jul 8, 2023

@pfilipko1 2 more notes:

  1. I see space ran out on the runner - I'll work to get that fixed:
ERROR: failed to solve: failed to compute cache key: write /var/lib/buildkit/runc-overlayfs/snapshots/snapshots/40/fs/usr/local/go/src/strconv/quote_test.go: no space left on device
Error: Process completed with exit code 1.
  1. I noticed a script I wrote in the past setup_runner_requirements.sh that we currently (in master) execute for the aarch64 build - the only one running on blank runners. You might need to add that as a step now in all jobs, keep that in mind.

@Jongy
Copy link
Contributor

Jongy commented Jul 16, 2023

@pfilipko1 to solve the dockerhub ratelimiting when using self-hosted runners, we can log in with the users configured in secrets. So basically, in all jobs - build exe, build container, test exe, test container - add these lines before the step to have it log in:

      - name: Login to DockerHub
        uses: docker/login-action@v1
        with:
          username: ${{ secrets.DOCKERHUB_USERNAME }}
          password: ${{ secrets.DOCKERHUB_TOKEN }}

@pfilipko1 pfilipko1 closed this Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants