Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate image & executable build into exe-in-image #790

Merged
merged 51 commits into from
Aug 11, 2023
Merged

Consolidate image & executable build into exe-in-image #790

merged 51 commits into from
Aug 11, 2023

Conversation

mpozniak95
Copy link
Contributor

Related Issue

#582

mpozniak95 added 26 commits May 9, 2023 09:05
@mpozniak95
Use gprofiler executable in gprofiler image
9f1601c
@mpozniak95
Merge remote-tracking branch 'origin/master' into consolidate_images
8a11c60
@mpozniak95
Change workflow to build,test,deploy executable and container in one …
c4a6897 
…flow
@mpozniak95
Add +x to gprofiler exe before running extract-resources
fe4c2ea
@mpozniak95
Add sudo to gprofiler extract resources
e325235
@mpozniak95
Download image from previous step of github workflow
37b6e51
@mpozniak95
Change sys.exit for os._exit when preventing cleaning resources
9f7e05b
@mpozniak95
Change os._exit() to os.kill(pid,sigkill)
0614217
@mpozniak95
Merge remote-tracking branch 'origin/master' into consolidate_images
69c6c34
@mpozniak95
Remove unecessary comment
5b01016
@mpozniak95
Add continue on error to extract-resources step
af18910
@mpozniak95
Copy resources instead of killing process
8f38614
@mpozniak95
Add -- before argument
fb38169
@mpozniak95
Add dirs_exists_ok to copying resources
f9ff117
@mpozniak95
Add sudo to tests
774460c
@mpozniak95
Merge remote-tracking branch 'origin/master' into consolidate_images
20cdc2d
@mpozniak95
Move sudo after defining env
5104f06
@mpozniak95
Remove sudo
2fa88ea
@mpozniak95
Add chmod +x to dockerfile
bff7f23
@mpozniak95
Fix typo
5845c07
@mpozniak95
Xfail tests with dotnet
95e57cd
@mpozniak95
Reformat test files
b093aec
@mpozniak95
Xfail app metadata test with dotnet
eed5847
@mpozniak95
Add possibility to build executable without staticx
ac47d71
@mpozniak95
Remove echo
f5f98d5
@mpozniak95
Enable to build aarch64 executable without staticx
3862ba6
@mpozniak95 mpozniak95 marked this pull request as ready for review May 19, 2023 09:40
@mpozniak95 mpozniak95 requested a review from Jongy May 19, 2023 09:40
@Jongy Jongy mentioned this pull request May 25, 2023
Draft
@Jongy Jongy added the enhancement New feature or request label May 25, 2023
Jongy
Jongy suggested changes Jul 8, 2023
View reviewed changes
Copy link
Contributor

@Jongy Jongy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I finished reviewing everything :)

Besides CI that runs on pull request, I'd want to test the new deployment jobs after all fixes. When you've fixed everything please coordinate with me a test. We'll need to edit some stuff to avoid pushing the latest image.

mpozniak95 added 16 commits July 31, 2023 11:48
@mpozniak95
Merge remote-tracking branch 'origin/master' into consolidate_images
16cfa10
@mpozniak95
Rename dockerfiles, rename stages in github workflow, remove duplicat…
b63f8cc 
…ed stage
@mpozniak95
Check for extract-resources right after parsing cmd args
60e6617
@mpozniak95
Merge remote-tracking branch 'origin/master' into consolidate_images
6bd5e1e
@mpozniak95
Fix workflow
942628f
@mpozniak95
Update dockerfile-lint.sh script
0b442ad
@mpozniak95
Fix using docker build command
4fe77b7
@mpozniak95
Add possibility to skip building exe in build_containers scripts
792fef4
@mpozniak95
Change dockerfile name in aarch64_exe script
e0db7cf
@mpozniak95
Copy gprofiler.output from executable build-stage
d016af1
@mpozniak95
Fix dockerfile
77a6859
@mpozniak95
Check tag only when running workflow on tagged branch
a28be97
@mpozniak95
Add skip-exe-build to build-container-x64 stage
5997bb1
@mpozniak95
Add docker push to deploy-container job
9ca3a2e
@mpozniak95
Rename workflow
f6e172f
@mpozniak95
Add job explanations at the top of workflow file
b3e58d0
@mpozniak95 mpozniak95 requested a review from Jongy August 7, 2023 10:40
Jongy
Jongy reviewed Aug 10, 2023
View reviewed changes
executable.Dockerfile Outdated Show resolved Hide resolved
@Jongy
Copy link
Contributor

Jongy commented Aug 10, 2023

I finished re-reviewing all past comments, I want to have one last go at the CI file and we'll be able to merge it.

Jongy
Jongy approved these changes Aug 11, 2023
View reviewed changes
Copy link
Contributor

@Jongy Jongy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge. I have some final nitpicks that I'll handle in a separate PR after this.

Good job @mpozniak95 , this is a core change with many different aspects and subtleties and you've handled all of them thoroughly and properly :)

@Jongy Jongy merged commit c7cc4a3 into intel:master Aug 11, 2023
This was referenced Aug 11, 2023
Closed
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcin-ol marcin-ol marcin-ol left review comments

@Jongy Jongy Jongy approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mpozniak95 @marcin-ol @Jongy