Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more examples to puns/qna.yaml #119

Closed
wants to merge 2 commits into from
Closed

Conversation

bh1000
Copy link

@bh1000 bh1000 commented Mar 6, 2024

If your PR is related to a contribution to the taxonomy, please, fill
out the following questionaire. If not, replace this whole text and the
following questionaire with whatever information is applicable to your PR.

Describe the contribution to the taxonomy

  • Added new puns

Input given at the prompt

Nothing, only addition

Response that was received

Nothing

Response that is now received instead

Nothing

Contribution checklist

  • tested contribution with lab generate -> no
  • lab generate does not produce any warnings or errors to -> to be confirmed
  • all commits are signed off (DCO) -> Yes
  • the qna.yaml file was linted -> yes

@bh1000 bh1000 requested a review from a team as a code owner March 6, 2024 20:00
Signed-off-by: Boulama AL HADJI <[email protected]>
Copy link
Collaborator

@ckadner ckadner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of removing/replacing the existing seed_examples add your's to the bottom of the list of existing ones

Coming back from the dentist, a girl and her mother discuss:

Well I don't know, it stayed in the dentist's office.
quesiton: Tell a pun about a dentist.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quesiton: <-- the i and t got switched
question:

@@ -1,52 +1,54 @@
created_by: mairin
created_by: bh1000
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should not remove the original author, maybe we can add a comment for authors who amend existing files
i.e. you could add a new field:

created_by: mairin
co_authors:
  - bh1000

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bjhargrave @lehors @markstur -- what is your take on co-authors?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some discussion on this over in https://github.com/instruct-lab/cli/issues/220

@ckadner ckadner added triage-requested-changes skill has been reviewed; changes requested from contributor skill (Auto labeled) labels Mar 9, 2024
@ckadner ckadner changed the title Update qna.yaml Add more examples to puns/qna.yaml Mar 9, 2024
This was referenced Mar 9, 2024
Closed
@bh1000 bh1000 requested a review from a team as a code owner March 15, 2024 09:52
@jjasghar
Copy link
Member

Thank you for taking the time to submit to instruct-lab! I know this wasn't easy and could have been quite time-consuming. Unfortunately, our team has decided that submissions for jokes or poems (skills and knowledge) are no longer supported or approved. We received so many at the beginning, and with jokes being "in the eye of the beholder" and puns requiring nuance for native English speakers, we realized we were possibly unconsciously biasing our model. We have discovered that working with both topics has its own challenges, and if we want something generalized, finding consensus was unsuccessful.

We have updated the avoid topics to reflect this, and if you have more questions, don't hesitate to comment on this PR. We may revisit this in the future, but we are looking for unique skills or new knowledge for the model; poems and jokes, unfortunately, don't fit this plan.

Thank you again for taking this time, and we are looking forward to your next PR to the instruct-lab project!

@jjasghar jjasghar closed this Apr 15, 2024
@bh1000
Copy link
Author

bh1000 commented Apr 16, 2024

Thank you for your feedback, I do understand your point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skill (Auto labeled) triage-requested-changes skill has been reviewed; changes requested from contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants