Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalize the created_by field requirement/design #657

Open
oindrillac opened this issue Mar 1, 2024 · 9 comments
Open

Finalize the created_by field requirement/design #657

oindrillac opened this issue Mar 1, 2024 · 9 comments
Assignees
Labels
enhancement New feature or request stale stale-bot has marked you as stale

Comments

@oindrillac
Copy link
Member

Currently the taxonomy processing can accept only one author. Make changes to the flow to accept more than one author for a file

@lehors
Copy link
Contributor

lehors commented Mar 2, 2024

I think this should rather be filed against the CLI.

@mairin mairin transferred this issue from instructlab/taxonomy Mar 3, 2024
@ckadner
Copy link
Collaborator

ckadner commented Mar 9, 2024

How about adding a new field co_authors:

#119 (comment)

created_by: mairin
co_authors:
  - bh1000

I should not break existing CLI code, just get ignored, but it does allow to record all editors

@JamesKunstle JamesKunstle added the enhancement New feature or request label Mar 12, 2024
@russellb
Copy link
Member

What's the value of the author field over what can be extracted from git history?

@anik120
Copy link
Contributor

anik120 commented Mar 12, 2024

I think this is more of a feature enhancement of the backend tools that's processing those qna.yml files. Afaik nothing in this cli does anything with those files. Let me reach out to some folks and get some clarifications

@russellb
Copy link
Member

I think this is more of a feature enhancement of the backend tools that's processing those qna.yml files. Afaik nothing in this cli does anything with those files. Let me reach out to some folks and get some clarifications

Sounds great. I think even if the backend desires to do something with author information, we can automate the extraction of that data and the result will be much more accurate as time goes on.

@anik120 anik120 self-assigned this Mar 12, 2024
@anik120
Copy link
Contributor

anik120 commented Mar 13, 2024

We discussed this in the call and here's the conclusion:

The created_by field is not actually being used by any component in the cli or the backend. It was introduced initially as a way to credit the authors, but that was before git was introduced in the picture. Now that this is all tracked in git, we can just get rid of the created_by field, since git tracks that for us anyway. So we'll be getting rid of the created_by filed all together. Opening up a PR in the taxonomy repo to remove that field from existing files.

@anik120
Copy link
Contributor

anik120 commented Mar 31, 2024

This had to be reverted since we were unaware that the schema structure for qna.yaml was being used as a first class schema. Which meant a change to the structure actually broke the components that assumed the first class schema. Opening this back up to finalize a soft decision and implement it: allow a list of authors instead of just one.

@anik120 anik120 reopened this Mar 31, 2024
@bjhargrave
Copy link
Contributor

After discussion in several standups today, I think there is general consensus that real author attribution information, for multiple authors, is in git (author in commit and Co-authored-by in commit messages aggregated over all commits which modify a file).

Therefore, we should use this issue to close on the subject of whether we can remove created_by from the yaml (schemas and any documentation and ultimately from existing yaml files).

  • Is there any requirement from a legal perspective on the created_by element? The git author information is actually more complete and trustworthy. @katesoule
  • Does the back end require the presence of the created_by element for any reason? If so, can this be addressed? @shivchander

@xukai92 xukai92 transferred this issue from instructlab/instructlab Apr 4, 2024
@xukai92 xukai92 changed the title Include more than one author in the created_by field Finalize the created_by field requirement/design Apr 4, 2024
Copy link

github-actions bot commented Jun 6, 2024

This issue has been automatically marked as stale because it has not had activity within 60 days. It will be automatically closed if no further activity occurs within 31 days.

@github-actions github-actions bot added the stale stale-bot has marked you as stale label Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request stale stale-bot has marked you as stale
Projects
None yet
Development

No branches or pull requests

7 participants