-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finalize the created_by field requirement/design #657
Comments
I think this should rather be filed against the CLI. |
How about adding a new field created_by: mairin
co_authors:
- bh1000 I should not break existing CLI code, just get ignored, but it does allow to record all editors |
What's the value of the author field over what can be extracted from git history? |
I think this is more of a feature enhancement of the backend tools that's processing those qna.yml files. Afaik nothing in this cli does anything with those files. Let me reach out to some folks and get some clarifications |
Sounds great. I think even if the backend desires to do something with author information, we can automate the extraction of that data and the result will be much more accurate as time goes on. |
We discussed this in the call and here's the conclusion: The |
Please see https://github.com/instruct-lab/cli/issues/220 for more details. Signed-off-by: Anik Bhattacharjee <[email protected]>
This had to be reverted since we were unaware that the schema structure for qna.yaml was being used as a first class schema. Which meant a change to the structure actually broke the components that assumed the first class schema. Opening this back up to finalize a soft decision and implement it: allow a list of authors instead of just one. |
After discussion in several standups today, I think there is general consensus that real author attribution information, for multiple authors, is in git ( Therefore, we should use this issue to close on the subject of whether we can remove
|
This issue has been automatically marked as stale because it has not had activity within 60 days. It will be automatically closed if no further activity occurs within 31 days. |
Currently the taxonomy processing can accept only one author. Make changes to the flow to accept more than one author for a file
The text was updated successfully, but these errors were encountered: