-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Improve Dutch translations and add Belgian Dutch #12368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Removed Dutch (Belgian) language entries from the i18n engine.
dusmartijngames
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As the author of the initial i18n Dutch PR, I have some considerations
|
|
||
| // nl_NL (Dutch) | ||
| huEngine->registerEntry("nl_NL", TXT_KEY_ANR_TITLE, "Applicatie Reageert Niet"); | ||
| huEngine->registerEntry("nl_NL", TXT_KEY_ANR_TITLE, "Applicatie reageert niet"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The capitalization was done intentionally seeing that the other languages also have capital letters for the titles.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not consistent with other Dutch language keys, and literally no reason for it aswell.
| return "Hyprland kon {count} essentieel bestand niet laden, geef de pakketbeheerder van uw distro de schuld voor slecht verpakkingswerk!"; | ||
| return "Hyprland kon {count} essentiële bestanden niet laden, geef de pakketbeheerder van uw distro de schuld voor slecht verpakkingswerk!"; | ||
| return "Hyprland kon {count} essentieel onderdeel niet laden, geef de pakketbeheerder van uw distro de schuld voor het slechte packagen!"; | ||
| return "Hyprland kon {count} essentiële onderdelen niet laden, geef de pakketbeheerder van uw distro de schuld voor het slechte packagen!"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While we would understand packagen it would, in my opinion, not be correct Dutch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IN tech dutch, people will rather say 'packagen' than 'verpakkingswerk', as one just doesn't really remind people of digital Packages like on Arch, but rather IRL boxes.
| huEngine->registerEntry("nl_NL", TXT_KEY_PERMISSION_REQUEST_PLUGIN, "Een applicatie <b>{app}</b> probeert een plugin te laden: <b>{plugin}</b>.\n\nWilt u dit toestaan?"); | ||
| huEngine->registerEntry("nl_NL", TXT_KEY_PERMISSION_REQUEST_KEYBOARD, | ||
| "Een nieuw toetsenbord is gedetecteerd: <b>{keyboard}</b>.\n\nWilt u toestemming geven dat het wordt gebruikt?"); | ||
| "Een nieuw toetsenbord is gedetecteerd: <b>{keyboard}</b>.\n\nWilt u het toestemming geven te worden gebruikt?"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO, this sounds kinda weird. Had that problem myself when translating. Maybe Wilt u het toestemming geven om gebruikt te worden would sound better,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay i get you here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO, this sounds kinda weird. Had that problem myself when translating. Maybe
Wilt u het toestemming geven om gebruikt te wordenwould sound better,
What about "in gebruik worden genomen"?
Describe your PR, what does it fix/add?
Improve Dutch translations and add Belgian Dutch.
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
/
Is it ready for merging, or does it need work?
It is ready for merging.